Code lint

Author: rjtokenring

src/arduino/app_bricks/sound_generator/__init__.py

@@ -90,12 +90,13 @@ def __init__(
     ):
         """Initialize the SoundGeneratorStreamer. Generates sound blocks for streaming, without internal playback.
         Args:
-            wave_form (str): The type of wave form to generate. Supported values
-                are "sine" (default), "square", "triangle" and "sawtooth".
             bpm (int): The tempo in beats per minute for note duration calculations.
-            master_volume (float): The master volume level (0.0 to 1.0).
+            time_signature (tuple): The time signature as (numerator, denominator).
             octaves (int): Number of octaves to generate notes for (starting from octave
                 0 up to octaves-1).
+            wave_form (str): The type of wave form to generate. Supported values
+                are "sine" (default), "square", "triangle" and "sawtooth".
+            master_volume (float): The master volume level (0.0 to 1.0).
             sound_effects (list, optional): List of sound effect instances to apply to the audio
                 signal (e.g., [SoundEffect.adsr()]). See SoundEffect class for available effects.
         """
@@ -258,6 +259,7 @@ def _apply_sound_effects(self, signal: np.ndarray, frequency: float) -> np.ndarr
         Apply the configured sound effects to the audio signal.
         Args:
             signal (np.ndarray): Input audio signal.
+            frequency (float): Frequency of the note being played.
         Returns:
             np.ndarray: Processed audio signal with sound effects applied.
         """
@@ -312,7 +314,7 @@ def play_polyphonic(self, notes: list[list[tuple[str, float]]], as_tone: bool =
                 if frequency >= 0.0:
                     if base_frequency is None:
                         base_frequency = frequency
-                    if as_tone == False:
+                    if not as_tone:
                         duration = self._note_duration(duration)
                     data = self._wave_gen.generate_block(float(frequency), duration, volume)
                     sequence_waves.append(data)
@@ -489,6 +491,7 @@ def __init__(
                 0 up to octaves-1).
             sound_effects (list, optional): List of sound effect instances to apply to the audio
                 signal (e.g., [SoundEffect.adsr()]). See SoundEffect class for available effects.
+            time_signature (tuple): The time signature as (numerator, denominator).
         """
 
         super().__init__(
@@ -511,12 +514,12 @@ def __init__(
     def start(self):
         if self._started.is_set():
             return
-        if self.external_speaker == False:
+        if not self.external_speaker:
             self._output_device.start(notify_if_started=False)
         self._started.set()
 
     def stop(self):
-        if self.external_speaker == False:
+        if not self.external_speaker:
             self._output_device.stop()
         self._started.clear()
 

src/arduino/app_bricks/sound_generator/effects.py

@@ -178,7 +178,7 @@ def __init__(self, bits: int = 4, reduction: int = 4):
                 """
                 Bitcrusher effect.
                 Args:
-                    bit_depth (int): Number of bits for quantization (1-16).
+                    bits (int): Bit depth for quantization (1-16).
                     reduction (int): Redeuction factor for downsampling (>=1).
                 """
                 self.bit_depth = np.clip(bits, 1, 16)

tests/arduino/app_bricks/sound_generator/test_effects.py

@@ -2,7 +2,6 @@
 #
 # SPDX-License-Identifier: MPL-2.0
 
-import pytest
 from arduino.app_bricks.sound_generator.effects import SoundEffect
 from arduino.app_bricks.sound_generator import SoundGenerator
 from arduino.app_utils.audio import WaveGenerator