refactor: log a warning for undeclared variables in brick configuration

Author: dido18

internal/orchestrator/app/validator.go

@@ -3,6 +3,7 @@ package app
 import (
 	"errors"
 	"fmt"
+	"log/slog"
 
 	"github.com/arduino/arduino-app-cli/internal/orchestrator/bricksindex"
 )
@@ -27,7 +28,7 @@ func ValidateBricks(a AppDescriptor, index *bricksindex.BricksIndex) error {
 		for appBrickName := range appBrick.Variables {
 			_, exist := indexBrick.GetVariable(appBrickName)
 			if !exist {
-				allErrors = errors.Join(allErrors, fmt.Errorf("variable %q does not exist on brick %q", appBrickName, indexBrick.ID))
+				slog.Warn("variable is referenced but not declared in the brick configuration", "variable", appBrickName, "brick", indexBrick.ID)
 			}
 		}
 

internal/orchestrator/app/validator_test.go

@@ -61,9 +61,9 @@ func TestValidateAppDescriptorBricks(t *testing.T) {
 			expectedError: errors.New("brick \"arduino:not_existing_brick\" not found"),
 		},
 		{
-			name:          "invalid if variable does not exist in the brick",
+			name:          "log a warning if variable does not exist in the brick",
 			filename:      "not-found-variable-app.yaml",
-			expectedError: errors.New("variable \"NOT_EXISTING_VARIABLE\" does not exist on brick \"arduino:arduino_cloud\""),
+			expectedError: nil,
 		},
 	}