fixing yaml ser

Author: giulio93

internal/orchestrator/bricks/bricks.go

@@ -89,7 +89,7 @@ func (s *Service) AppBrickInstancesList(a *app.ArduinoApp) (AppBrickInstancesRes
 			Author:          "Arduino", // TODO: for now we only support our bricks
 			Category:        brick.Category,
 			Status:          "installed",
-			ModelRequired:   brick.ModelRequired,
+			ModelRequired:   brick.ModelRequired, // TODO: in case is not set by the user, should we return false?
 			ModelID:         brickInstance.Model, // TODO: in case is not set by the user, should we return the default model?
 			Variables:       variablesMap,        // TODO: do we want to show also the default value of not explicitly set variables?
 			ConfigVariables: configVariables,

internal/orchestrator/bricks/types.go

@@ -26,7 +26,7 @@ type BrickListItem struct {
 	Description   string   `json:"description"`
 	Category      string   `json:"category"`
 	Status        string   `json:"status"`
-	ModelRequired bool     `json:"model_required"`
+	ModelRequired bool     `json:"require_model"`
 	Models        []string `json:"models"`
 }
 
@@ -42,7 +42,7 @@ type BrickInstance struct {
 	Status          string                `json:"status"`
 	Variables       map[string]string     `json:"variables,omitempty" description:"Deprecated: use config_variables instead. This field is kept for backward compatibility."`
 	ConfigVariables []BrickConfigVariable `json:"config_variables,omitempty"`
-	ModelRequired   bool                  `json:"model_required,omitempty"`
+	ModelRequired   bool                  `json:"require_model,omitempty"`
 	ModelID         string                `json:"model,omitempty"`
 }
 
@@ -75,7 +75,7 @@ type BrickDetailsResult struct {
 	Description   string                   `json:"description"`
 	Category      string                   `json:"category"`
 	Status        string                   `json:"status"`
-	ModelRequired bool                     `json:"model_required"`
+	ModelRequired bool                     `json:"require_model"`
 	Variables     map[string]BrickVariable `json:"variables,omitempty"`
 	Readme        string                   `json:"readme"`
 	ApiDocsPath   string                   `json:"api_docs_path"`

internal/orchestrator/bricksindex/bricks_index.go

@@ -55,10 +55,9 @@ type Brick struct {
 	Category                  string          `yaml:"category,omitempty"`
 	RequiresDisplay           string          `yaml:"requires_display,omitempty"`
 	RequireContainer          bool            `yaml:"require_container"`
-	RequireModel              bool            `yaml:"require_model"`
 	Variables                 []BrickVariable `yaml:"variables,omitempty"`
 	Ports                     []string        `yaml:"ports,omitempty"`
-	ModelRequired             bool            `yaml:"model_required,omitempty"`
+	ModelRequired             bool            `yaml:"require_model,omitempty"`
 	ModelName                 string          `yaml:"model_name,omitempty"`
 	MountDevicesIntoContainer bool            `yaml:"mount_devices_into_container,omitempty"`
 	RequiredDevices           []string        `yaml:"required_devices,omitempty"`

internal/orchestrator/bricksindex/bricks_index_test.go

@@ -173,7 +173,7 @@ func TestBricksIndex(t *testing.T) {
 	require.True(t, found)
 	require.Equal(t, "Image Classification", b.Name)
 	require.Equal(t, "mobilenet-image-classification", b.ModelName)
-	require.True(t, b.RequireModel)
+	require.True(t, b.ModelRequired)
 	require.Len(t, b.Variables, 2)
 	require.Equal(t, "CUSTOM_MODEL_PATH", b.Variables[0].Name)
 	require.Equal(t, "/opt/models/ei/", b.Variables[0].DefaultValue)

internal/orchestrator/orchestrator.go

@@ -670,7 +670,7 @@ type AppDetailedBrick struct {
 	ID            string `json:"id" required:"true"`
 	Name          string `json:"name" required:"true"`
 	Category      string `json:"category,omitempty"`
-	ModelRequired bool   `json:"model_required,omitempty"`
+	ModelRequired bool   `json:"require_model,omitempty"`
 }
 
 func AppDetails(