fix(update): make sure we always return underline error (#95)

lucarin91 · web-flow · commit f761ee684ce4 · 2025-11-21T10:14:58.000+01:00
diff --git a/internal/update/apt/service.go b/internal/update/apt/service.go
@@ -287,7 +287,10 @@ func restartServices(ctx context.Context) error {
 	if err != nil {
 		return err
 	}
-	return needRestartCmd.RunWithinContext(ctx)
+	if out, err := needRestartCmd.RunAndCaptureCombinedOutput(ctx); err != nil {
+		return fmt.Errorf("error running needrestart command: %w: %s", err, out)
+	}
+	return nil
 }
 
 func listUpgradablePackages(ctx context.Context, matcher func(update.UpgradablePackage) bool) ([]update.UpgradablePackage, error) {

Original file line number	Diff line number	Diff line change
`@@ -287,7 +287,10 @@ func restartServices(ctx context.Context) error {`
`287`	`287`	`if err != nil {`
`288`	`288`	`return err`
`289`	`289`	`}`
`290`		`- return needRestartCmd.RunWithinContext(ctx)`
	`290`	`+ if out, err := needRestartCmd.RunAndCaptureCombinedOutput(ctx); err != nil {`
	`291`	`+ return fmt.Errorf("error running needrestart command: %w: %s", err, out)`
	`292`	`+ }`
	`293`	`+ return nil`
`291`	`294`	`}`
`292`	`295`
`293`	`296`	`func listUpgradablePackages(ctx context.Context, matcher func(update.UpgradablePackage) bool) ([]update.UpgradablePackage, error) {`