Skip to content

Commit c34995b

Browse files
committed
Nicer error handling
1 parent 7784863 commit c34995b

File tree

1 file changed

+7
-5
lines changed
  • internal/arduino/builder/internal/utils

1 file changed

+7
-5
lines changed

internal/arduino/builder/internal/utils/utils.go

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@
1616
package utils
1717

1818
import (
19+
"errors"
20+
"io/fs"
1921
"os"
2022
"strings"
2123
"unicode"
@@ -93,16 +95,16 @@ func ObjFileIsUpToDate(sourceFile, objectFile, dependencyFile *paths.Path) (bool
9395
}
9496
for _, dep := range deps.Dependencies[1:] {
9597
depStat, err := os.Stat(dep)
96-
if err != nil && !os.IsNotExist(err) {
98+
if err != nil {
99+
if errors.Is(err, fs.ErrNotExist) {
100+
logrus.Debugf("Not found: %v", dep)
101+
return false, nil
102+
}
97103
// There is probably a parsing error of the dep file
98104
// Ignore the error and trigger a full rebuild anyway
99105
logrus.WithError(err).Debugf("Failed to read: %v", dep)
100106
return false, nil
101107
}
102-
if os.IsNotExist(err) {
103-
logrus.Debugf("Not found: %v", dep)
104-
return false, nil
105-
}
106108
if depStat.ModTime().After(objectFileStat.ModTime()) {
107109
logrus.Debugf("%v newer than %v", dep, objectFile)
108110
return false, nil

0 commit comments

Comments
 (0)