Commit d0fcc98
committed
Use more efficient release artifact replacement approach
The "Release" GitHub Actions workflow automatically generates releases of the project. This is done for a range of host
architectures, including macOS. The macOS builds are then put through a notarization process in a dedicated workflow
job.
The builds are transferred between jobs by GitHub Actions workflow artifacts. The "create-release-artifacts" job
produces macOS workflow artifacts containing non-notarized builds, which must then be replaced after the builds are
notarized by the "notarize-macos" job.
Previously, the approach chosen to accomplish this replacement was to use the community created
"geekyeggo/delete-artifact" action to delete each artifact after it had been downloaded by the "notarize-macos" job,
then replacing it by uploading the notarized version using the "actions/upload-artifact" action.
The ability to overwrite workflows was recently added to the "actions/upload-artifact" action. This behavior is enabled
by setting the action's `overwrite` input to `true`. By using this feature, we avoid the need to delete the artifact and
thus the dependence on the "geekyeggo/delete-artifact" action is avoided, making the workflow more simple, easier to
maintain, and more secure.1 parent 2a92970 commit d0fcc98
1 file changed
+2
-6
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
120 | 120 | | |
121 | 121 | | |
122 | 122 | | |
123 | | - | |
124 | | - | |
125 | | - | |
126 | | - | |
127 | | - | |
128 | 123 | | |
129 | 124 | | |
130 | 125 | | |
| |||
190 | 185 | | |
191 | 186 | | |
192 | 187 | | |
193 | | - | |
| 188 | + | |
194 | 189 | | |
195 | 190 | | |
196 | 191 | | |
197 | 192 | | |
| 193 | + | |
198 | 194 | | |
199 | 195 | | |
200 | 196 | | |
| |||
0 commit comments