Commit fa918e4
committed
Use standard position for non-configuration
In cases where some project-specific configuration of reusable GitHub Actions workflows must be done via workflow
environment variables, the standard practice is to place the global `env` mapping near the top of the workflow to make
them easily accessible to the project maintainer. However, in other cases the mapping does not contain any values that
require adjustment. In this case, the established practice is to place it after the `on` mapping.
Previously, the `env` mapping of the "Sync Labels" workflow was used to define the project's standard Node.js version,
and thus the mapping was placed at the top of the workflow. However, this configuration was obviated by the change to
defining the Node.js value in the `package.json` file. So the `env` mapping is no longer used for per-project
configuration in this workflow and thus it should be moved below the `on` mapping.env mapping in workflow1 parent f2e387d commit fa918e4
1 file changed
+4
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | | - | |
6 | | - | |
7 | | - | |
8 | 4 | | |
9 | 5 | | |
10 | 6 | | |
| |||
27 | 23 | | |
28 | 24 | | |
29 | 25 | | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
| |||
0 commit comments