Commit 7a44068
committed
Don't upload multiple times to same artifact in "Compare Performance" workflow
The "Compare Performance" GitHub Actions workflow is configured to time indexing runs at the tip ref, and then do the same for the base ref. The times are then compared to provide information regarding whether a proposed change would have a significant performance impact. This is done by using a job matrix in the GitHub Actions workflow to
perform each of the runs in a parallel GitHub Actions workflow job. A GitHub Actions workflow artifact was used to
transfer the files containing the data for each run between sequential jobs in the workflow. The
"actions/upload-artifact" and "actions/download-artifact" actions are used for this purpose.
Previously, a single artifact was used for the transfer of all the files, with each of the parallel jobs uploading its
own generated files to that artifact. However, support for uploading multiple times to a single artifact was dropped in
version 4.0.0 of the "actions/upload-artifact" action. So it is now necessary to use a dedicated artifact for each of
the builds. These can be downloaded in aggregate by using the artifact name globbing and merging features which were
introduced in version 4.1.0 of the "actions/download-artifact" action.1 parent a2819b5 commit 7a44068
1 file changed
+12
-7
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
| 4 | + | |
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| |||
85 | 85 | | |
86 | 86 | | |
87 | 87 | | |
88 | | - | |
| 88 | + | |
| 89 | + | |
89 | 90 | | |
90 | 91 | | |
91 | | - | |
| 92 | + | |
| 93 | + | |
92 | 94 | | |
93 | 95 | | |
94 | | - | |
| 96 | + | |
| 97 | + | |
95 | 98 | | |
96 | 99 | | |
97 | | - | |
| 100 | + | |
| 101 | + | |
98 | 102 | | |
99 | 103 | | |
100 | 104 | | |
| |||
298 | 302 | | |
299 | 303 | | |
300 | 304 | | |
301 | | - | |
| 305 | + | |
302 | 306 | | |
303 | 307 | | |
304 | 308 | | |
| |||
312 | 316 | | |
313 | 317 | | |
314 | 318 | | |
315 | | - | |
| 319 | + | |
316 | 320 | | |
| 321 | + | |
317 | 322 | | |
318 | 323 | | |
319 | 324 | | |
| |||
0 commit comments