From 97a1638eb1d3e1ebe3baaf593895cd6e0a367ad1 Mon Sep 17 00:00:00 2001 From: per1234 Date: Mon, 4 Nov 2024 20:22:01 -0800 Subject: [PATCH] Only download required artifact in notarization job of release workflows GitHub Workflows are used to automatically generate and publish production and nightly releases of the project. This is done for a range of host architectures, including macOS. The macOS builds are then put through a notarization process in a dedicated workflow job. GitHub Actions workflow artifacts are used to transfer the generated files between sequential jobs in the workflow. The builds are transferred between jobs by GitHub Actions workflow artifacts, one for each host architecture. Previously, the "notarize-macos" job matrix that performs the notarization unnecessarily downloaded all the build artifacts, even though each job only requires the relevant macOS artifact. This is inefficient. The better approach is to configure the "notarize-macos" jobs to only download the artifact they require. --- workflow-templates/publish-go-nightly-task.yml | 3 +-- workflow-templates/release-go-task.yml | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/workflow-templates/publish-go-nightly-task.yml b/workflow-templates/publish-go-nightly-task.yml index 00bbf1db..8461b3ee 100644 --- a/workflow-templates/publish-go-nightly-task.yml +++ b/workflow-templates/publish-go-nightly-task.yml @@ -101,8 +101,7 @@ jobs: - name: Download artifacts uses: actions/download-artifact@v4 with: - pattern: ${{ env.ARTIFACT_PREFIX }}* - merge-multiple: true + name: ${{ env.ARTIFACT_PREFIX }}${{ matrix.build.artifact-suffix }} path: ${{ env.DIST_DIR }} - name: Import Code-Signing Certificates diff --git a/workflow-templates/release-go-task.yml b/workflow-templates/release-go-task.yml index d89ebebc..6fd67548 100644 --- a/workflow-templates/release-go-task.yml +++ b/workflow-templates/release-go-task.yml @@ -110,8 +110,7 @@ jobs: - name: Download artifacts uses: actions/download-artifact@v4 with: - pattern: ${{ env.ARTIFACT_PREFIX }}* - merge-multiple: true + name: ${{ env.ARTIFACT_PREFIX }}${{ matrix.build.artifact-suffix }} path: ${{ env.DIST_DIR }} - name: Import Code-Signing Certificates