Skip to content

Commit b6aea9c

Browse files
docs: improved grammar (#131)
Signed-off-by: Kostis Kapelonis <kostis@codefresh.io>
1 parent e711b72 commit b6aea9c

File tree

1 file changed

+19
-19
lines changed

1 file changed

+19
-19
lines changed

docs/CONTRIBUTING.md

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,11 @@ The Argo Rollouts Gateway API plugin needs the main Argo Rollouts controller to
2929

3030
When the Argo Rollouts controller starts, it reads the ConfigMap named `argo-rollouts-config` (from the namespace in which controller is located) from the API server of the k8s cluster it is running on.
3131

32-
If this configmap is present, the Argol Rollouts controller validates its content and then loads the plugin that is defined there. It is important to understand that this process happens only at the beginning and **only once** during the controller startup. ,
32+
If this configmap is present, the Argo Rollouts controller validates its content and then loads the plugin that is defined there. It is important to understand that this process happens only at the beginning and **only once** during the controller startup.
3333

34-
This means that if you change the `argo-rollouts-config` configmap or if you create it after the Argo Rollouts controller is already up you will need to restart the controller for the changes to take effect.
34+
This means that if you change the `argo-rollouts-config` configmap or if you create it after the Argo Rollouts controller is already up, you will need to restart the controller for the changes to take effect.
3535

36-
The Argo Rollouts Controller uses this config map to understand where to load its plugins from. When Argo Rollouts learns their locations it downloads and executes them as separate RPC servers in the same pod. When the controller detects [specific Rollout events](https://argo-rollouts.readthedocs.io/en/stable/features/specification/), for example events corresponding to the `SetWeight` action, it makes specific remote procedure calls to the respective RPC server and waits for a response.
36+
The Argo Rollouts Controller uses this config map to understand where to load its plugins from. When Argo Rollouts learns their locations, it downloads and executes them as separate RPC servers in the same pod. When the controller detects [specific Rollout events](https://argo-rollouts.readthedocs.io/en/stable/features/specification/), for example events corresponding to the `SetWeight` action, it makes specific remote procedure calls to the respective RPC server and waits for a response.
3737

3838
Here is a diagram illustrating the main aspects of architecture:
3939

@@ -64,17 +64,17 @@ To start developing the plugin do the following
6464

6565

6666
1. Start your local Kubernetes cluster
67-
1. Create a ConfigMap named `argo-rollouts-config` in the namespace of Argo Rollouts controller. We will run it locally so its namespace will be `default`
67+
1. Create a ConfigMap named `argo-rollouts-config` in the namespace of the Argo Rollouts controller. We will run it locally so its namespace will be `default`
6868
2. Run `make local-build` to create a local build of the plugin binary. In the `argo-rollouts-config` manifest specify the path to this local build by using a file directive
6969
```
7070
file://<path to the local build>
7171
```
72-
3. Install required CRDs for Argo Rollouts deploy the controller. For that you can run
72+
3. Install required CRDs for Argo Rollouts and deploy the controller. For that you can run
7373
```bash
7474
kubectl create namespace argo-rollouts
7575
kubectl apply -n argo-rollouts -f https://github.com/argoproj/argo-rollouts/releases/latest/download/install.yaml
7676
```
77-
After that delete the in cluster Argo Rollouts controller deployment as we will run controller locally (We only needed the CRDs).
77+
After that, delete the in-cluster Argo Rollouts controller deployment as we will run controller locally (We only needed the CRDs).
7878
4. Run locally the Argo Rollouts controller
7979
```bash
8080
cd ~/go/src/github.com/argoproj/argo-rollouts
@@ -84,7 +84,7 @@ go run ./cmd/rollouts-controller/main.go
8484

8585
## Making releases
8686

87-
1. Write in **/RELEASE_NOTES.md** the description of the future release
87+
1. Write the description of the future release in **/RELEASE_NOTES.md**
8888
2. Create a tag in the `main` branch
8989
```bash
9090
git tag release-v[0-9]+.[0-9]+.[0-9]+
@@ -94,7 +94,7 @@ If you prefer to make pre-release run
9494
git tag release-v[0-9]+.[0-9]+.[0-9]+-rc[0-9]+
9595
```
9696
3. Push the tag to the remote repository
97-
4. The pushed tag will trigger [a GitHub actions workflow](https://github.com/argoproj-labs/rollouts-plugin-trafficrouter-gatewayapi/blob/main/.github/workflows/release.yaml) that will create a corresponding tag `v[0-9]+.[0-9]+.[0-9]+` or `v[0-9]+.[0-9]+.[0-9]+-rc[0-9]+` and will then delete your tag. Therefore after pushing the tag to the remote repository you also need to delete it locally. When the workflow has finished its work you can run **git pull** and you will see new tag.
97+
4. The pushed tag will trigger [a GitHub Actions workflow](https://github.com/argoproj-labs/rollouts-plugin-trafficrouter-gatewayapi/blob/main/.github/workflows/release.yaml) that will create a corresponding tag `v[0-9]+.[0-9]+.[0-9]+` or `v[0-9]+.[0-9]+.[0-9]+-rc[0-9]+` and will then delete your tag. Therefore, after pushing the tag to the remote repository, you also need to delete it locally. When the workflow has finished its work, you can run **git pull** and you will see the new tag.
9898

9999
## Running Unit Tests
100100

@@ -113,34 +113,34 @@ make e2e-tests
113113

114114
This command will
115115

116-
1. Create local cluster **gatewayapi-plugin-e2e** using tools [kind](https://kind.sigs.k8s.io/) and [docker](https://www.docker.com/). You need to install them.
117-
2. Setup cluster using instruments [helm](https://helm.sh/) and [kubectl](https://kubernetes.io/docs/reference/kubectl/). You need to install them.
118-
3. Runs tests in **/test/e2e** folder.
119-
4. Delete all resources from created cluster.
120-
5. Delete created cluster.
116+
1. Create a local cluster **gatewayapi-plugin-e2e** using tools [kind](https://kind.sigs.k8s.io/) and [docker](https://www.docker.com/). You need to install them.
117+
2. Set up the cluster using tools [helm](https://helm.sh/) and [kubectl](https://kubernetes.io/docs/reference/kubectl/). You need to install them.
118+
3. Run tests in the **/test/e2e** folder.
119+
4. Delete all resources from the created cluster.
120+
5. Delete the created cluster.
121121

122-
**Note:** It is used Traefik in e2e tests.
122+
**Note:** Traefik is used in e2e tests.
123123

124-
If you want to leave working cluster with needing setup at the end you should run the following command
124+
If you want to leave the working cluster with the needed setup at the end, you should run the following command
125125
```
126126
make CLUSTER_DELETE=false e2e-tests
127127
```
128128

129-
After this command you can want to run again all tests. Although you can run again **make CLUSTER_DELETE=false e2e-tests** command, it is recommended to use this command
129+
After this command, you may want to run all tests again. Although you can run the **make CLUSTER_DELETE=false e2e-tests** command again, it is recommended to use this command
130130
```
131131
make run-e2e-tests
132132
```
133-
as you have already had cluster setup.
133+
as you already have the cluster set up.
134134

135-
If you want to run specific e2e tests then you can these commands
135+
If you want to run specific e2e tests, then you can use these commands
136136
```
137137
make RUN=<reg-exp> e2e-tests
138138
```
139139
or
140140
```
141141
make RUN=<reg-exp> run-e2e-tests
142142
```
143-
reg-exp - the value you would set for the **-run** flag of **go test** command
143+
reg-exp - the value you would set for the **-run** flag of the **go test** command
144144

145145

146146
## Cleaning up after failed E2E tests

0 commit comments

Comments
 (0)