fix(datepicker): reset state properly when clearOnSameDateClick is false (#706)

Author: arthurdenner

src/index.tsx

@@ -296,26 +296,11 @@ class SemanticDatepicker extends React.Component<
       format,
       keepOpenOnSelect,
       onChange,
-      clearOnSameDateClick,
       formatOptions,
     } = this.props;
 
     if (!newDate) {
-      // if clearOnSameDateClick is true (this is the default case)
-      // then reset the state. This is what was previously the default
-      // behavior, without a specific prop.
-      if (clearOnSameDateClick) {
-        this.resetState(event);
-      } else {
-        // Don't reset the state. Instead, close or keep open the
-        // datepicker according to the value of keepOpenOnSelect.
-        // Essentially, follow the default behavior of clicking a date
-        // but without changing the value in state.
-        this.setState({
-          isVisible: keepOpenOnSelect,
-        });
-      }
-
+      this.resetState(event);
       return;
     }
 

src/pickers/basic.tsx

@@ -7,14 +7,18 @@ class DatePicker extends React.Component<BasicDatePickerProps> {
     { selectable, date },
     event: React.SyntheticEvent
   ) => {
-    const { selected: selectedDate, onChange } = this.props;
+    const { clearOnSameDateClick, selected: selectedDate, onChange } = this.props;
 
     if (!selectable) {
       return;
     }
 
     let newDate = date;
-    if (selectedDate && selectedDate.getTime() === date.getTime()) {
+    if (
+      selectedDate &&
+      selectedDate.getTime() === date.getTime() &&
+      clearOnSameDateClick
+    ) {
       newDate = null;
     }
 

src/types/index.ts

@@ -99,6 +99,7 @@ export type BaseDatePickerProps = DayzedProps & {
 };
 
 export interface BasicDatePickerProps extends BaseDatePickerProps {
+  clearOnSameDateClick?: boolean
   onChange: (event: React.SyntheticEvent, date: Date | null) => void;
   selected: Date;
 }