fix: improved assert error messages

gurvinder-dhillon · gurvinder-dhillon · commit 04305847c579 · 2025-04-07T20:50:43.000-07:00
diff --git a/src/tools/browser_assert.ts b/src/tools/browser_assert.ts
@@ -47,7 +47,7 @@ export const browser_assert = tool(
                             console.log(`[Assert Tool] Performing assertion`);
 
                             // Create descriptive message for both success and error cases
-                            const message = `${element} should ${assertion}${expected ? ` with text "${expected}"` : ''}`;
+                            const message = `${element} ${assertion} ${expected || ''}`;
 
                             switch (assertion.toLowerCase())
                             {
@@ -82,9 +82,8 @@ export const browser_assert = tool(
             return result;
         } catch (error)
         {
-            // Simple error handling using Playwright's built-in error messages
-            const errorMessage = `Assertion failed: ${error instanceof Error ? error.message : 'Unknown error'}`;
-            console.error(`[Assert Tool] Error:`, errorMessage);
+            const errorMessage = error instanceof Error ? error.message : 'Unknown error';
+            console.error(`[Assert Tool] Error: ${errorMessage}`);
             return errorMessage;
 
         }
diff --git a/src/tools/browser_page_assert.ts b/src/tools/browser_page_assert.ts
@@ -37,7 +37,7 @@ export const browser_page_assert = tool(
                             console.log(`[Page Assert Tool] Performing assertion`);
 
                             // Create descriptive message for both success and error cases
-                            const message = `Page should ${assertion}${expected ? ` "${expected}"` : ''}`;
+                            const message = `${assertion} ${expected || ''}`;
 
                             switch (assertion.toLowerCase())
                             {

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ export const browser_assert = tool(`
`47`	`47`	console.log(`[Assert Tool] Performing assertion`);
`48`	`48`
`49`	`49`	`// Create descriptive message for both success and error cases`
`50`		- const message = `${element} should ${assertion}${expected ? ` with text "${expected}"` : ''}`;
	`50`	+ const message = `${element} ${assertion} ${expected \|\| ''}`;
`51`	`51`
`52`	`52`	`switch (assertion.toLowerCase())`
`53`	`53`	`{`
`@@ -82,9 +82,8 @@ export const browser_assert = tool(`
`82`	`82`	`return result;`
`83`	`83`	`} catch (error)`
`84`	`84`	`{`
`85`		`- // Simple error handling using Playwright's built-in error messages`
`86`		- const errorMessage = `Assertion failed: ${error instanceof Error ? error.message : 'Unknown error'}`;
`87`		- console.error(`[Assert Tool] Error:`, errorMessage);
	`85`	`+ const errorMessage = error instanceof Error ? error.message : 'Unknown error';`
	`86`	+ console.error(`[Assert Tool] Error: ${errorMessage}`);
`88`	`87`	`return errorMessage;`
`89`	`88`
`90`	`89`	`}`
Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ export const browser_page_assert = tool(`
`37`	`37`	console.log(`[Page Assert Tool] Performing assertion`);
`38`	`38`
`39`	`39`	`// Create descriptive message for both success and error cases`
`40`		- const message = `Page should ${assertion}${expected ? ` "${expected}"` : ''}`;
	`40`	+ const message = `${assertion} ${expected \|\| ''}`;
`41`	`41`
`42`	`42`	`switch (assertion.toLowerCase())`
`43`	`43`	`{`