Simplify prefer-power-assert tests

novemberborn · novemberborn · commit 382d52fcd885 · 2020-08-16T13:56:21.000+02:00
Remove js-combinatorics which has stopped supporting CJS. It's not necessary to test this number of permutations, some of which are not even supported by AVA.
diff --git a/package.json b/package.json
@@ -50,7 +50,6 @@
 		"eslint-ava-rule-tester": "^4.0.0",
 		"eslint-plugin-eslint-plugin": "^2.3.0",
 		"execa": "^4.0.2",
-		"js-combinatorics": "^0.6.1",
 		"listr": "^0.14.3",
 		"outdent": "^0.7.1",
 		"pify": "^5.0.0",
diff --git a/test/prefer-power-assert.js b/test/prefer-power-assert.js
@@ -1,6 +1,5 @@
 const test = require('ava');
 const avaRuleTester = require('eslint-ava-rule-tester');
-const {permutationCombination} = require('js-combinatorics');
 const rule = require('../rules/prefer-power-assert');
 
 const ruleTester = avaRuleTester(test, {
@@ -92,8 +91,8 @@ function testWithModifier(modifier) {
 	});
 }
 
-for (const modifiers of permutationCombination(['skip', 'only', 'cb', 'serial']).toArray()) {
-	testWithModifier(modifiers.join('.'));
+for (const modifiers of ['skip', 'only', 'cb', 'serial']) {
+	testWithModifier(modifiers);
 }
 
 function testDeclaration(declaration) {

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,5 @@`
`1`	`1`	`const test = require('ava');`
`2`	`2`	`const avaRuleTester = require('eslint-ava-rule-tester');`
`3`		`-const {permutationCombination} = require('js-combinatorics');`
`4`	`3`	`const rule = require('../rules/prefer-power-assert');`
`5`	`4`
`6`	`5`	`const ruleTester = avaRuleTester(test, {`
`@@ -92,8 +91,8 @@ function testWithModifier(modifier) {`
`92`	`91`	`});`
`93`	`92`	`}`
`94`	`93`
`95`		`-for (const modifiers of permutationCombination(['skip', 'only', 'cb', 'serial']).toArray()) {`
`96`		`- testWithModifier(modifiers.join('.'));`
	`94`	`+for (const modifiers of ['skip', 'only', 'cb', 'serial']) {`
	`95`	`+ testWithModifier(modifiers);`
`97`	`96`	`}`
`98`	`97`
`99`	`98`	`function testDeclaration(declaration) {`