encapsulate SetSDK for Secret fields

Encapsulates the code that generates Go code for setting an SDK Input shape
from the value of a SecretKeyReference in a separate `setSDKForSecret`
function in `pkg/generate/code` and creates a `CRD.IsSecretField` that
accepts a field path and returns whether the field at that field path is
a SecretKeyReference.

Author: jaypipes

pkg/generate/code/set_sdk.go

@@ -165,7 +165,6 @@ func SetSDK(
 	}
 
 	opConfig, override := cfg.OverrideValues(op.Name)
-	fieldConfigs := cfg.ResourceFields(r.Names.Original)
 	for memberIndex, memberName := range inputShape.MemberNames() {
 		if r.UnpacksAttributesMap() && memberName == "Attributes" {
 			continue
@@ -190,22 +189,6 @@ func SetSDK(
 			}
 		}
 
-		fc, ok := fieldConfigs[memberName]
-		if ok && fc.IsSecret {
-			out += fmt.Sprintf("%sif %s.Spec.%s != nil {\n", indent, sourceVarName, memberName)
-			out += fmt.Sprintf("%s%stmpSecret, err := rm.rr.SecretValueFromReference(ctx, %s.Spec.%s)\n", indent,
-				indent, sourceVarName, memberName)
-			out += fmt.Sprintf("%s%sif err != nil {\n", indent, indent)
-			out += fmt.Sprintf("%s%s%sreturn nil, err\n", indent, indent, indent)
-			out += fmt.Sprintf("%s%s}\n", indent, indent)
-			out += fmt.Sprintf("%s%sif tmpSecret != \"\" {\n", indent, indent)
-			out += fmt.Sprintf("%s%s%s%s.Set%s(%s)\n", indent, indent, indent,
-				targetVarName, memberName, "tmpSecret")
-			out += fmt.Sprintf("%s%s}\n", indent, indent)
-			out += fmt.Sprintf("%s}\n", indent)
-			continue
-		}
-
 		if r.IsPrimaryARNField(memberName) {
 			// if ko.Status.ACKResourceMetadata != nil && ko.Status.ACKResourceMetadata.ARN != nil {
 			//     res.SetTopicArn(string(*ko.Status.ACKResourceMetadata.ARN))
@@ -252,6 +235,17 @@ func SetSDK(
 		}
 		sourceAdaptedVarName += "." + f.Names.Camel
 
+		if r.IsSecretField(memberName) {
+			out += setSDKForSecret(
+				cfg, r,
+				memberName,
+				targetVarName,
+				sourceAdaptedVarName,
+				indentLevel,
+			)
+			continue
+		}
+
 		memberShapeRef, _ := inputShape.MemberRefs[memberName]
 		memberShape := memberShapeRef.Shape
 
@@ -777,6 +771,66 @@ func setSDKForContainer(
 	}
 }
 
+// setSDKForSecret returns a string of Go code that sets a target variable to
+// the value of a Secret when the type of the source variable is a
+// SecretKeyReference.
+//
+// The Go code output from this function looks like this:
+//
+// if ko.Spec.MasterUserPassword != nil {
+//     tmpSecret, err := rm.rr.SecretValueFromReference(ctx, ko.Spec.MasterUserPassword)
+//     if err != nil {
+//         return nil, err
+//     }
+//     if tmpSecret != "" {
+//         res.SetMasterUserPassword(tmpSecret)
+//     }
+// }
+func setSDKForSecret(
+	cfg *ackgenconfig.Config,
+	r *model.CRD,
+	// The name of the SDK Shape field we're setting
+	targetFieldName string,
+	// The variable name that we want to set a value on
+	targetVarName string,
+	// The CR field that we access our source value from
+	sourceVarName string,
+	indentLevel int,
+) string {
+	out := ""
+	indent := strings.Repeat("\t", indentLevel)
+	secVar := "tmpSecret"
+
+	// if ko.Spec.MasterUserPassword != nil {
+	out += fmt.Sprintf(
+		"%sif %s != nil {\n",
+		indent, sourceVarName,
+	)
+	//     tmpSecret, err := rm.rr.SecretValueFromReference(ctx, ko.Spec.MasterUserPassword)
+	out += fmt.Sprintf(
+		"%s\t%s, err := rm.rr.SecretValueFromReference(ctx, %s)\n",
+		indent, secVar, sourceVarName,
+	)
+	//     if err != nil {
+	//         return nil, err
+	//     }
+	out += fmt.Sprintf("%s\tif err != nil {\n", indent)
+	out += fmt.Sprintf("%s\t\treturn nil, err\n", indent)
+	out += fmt.Sprintf("%s\t}\n", indent)
+	//     if tmpSecret != "" {
+	//         res.SetMasterUserPassword(tmpSecret)
+	//     }
+	out += fmt.Sprintf("%s\tif tmpSecret != \"\" {\n", indent)
+	out += fmt.Sprintf(
+		"%s\t\t%s.Set%s(%s)\n",
+		indent, targetVarName, targetFieldName, secVar,
+	)
+	out += fmt.Sprintf("%s\t}\n", indent)
+	// }
+	out += fmt.Sprintf("%s}\n", indent)
+	return out
+}
+
 // setSDKForStruct returns a string of Go code that sets a target variable
 // value to a source variable when the type of the source variable is a struct.
 func setSDKForStruct(

pkg/model/crd.go

@@ -292,6 +292,17 @@ func (r *CRD) IsPrimaryARNField(fieldName string) bool {
 		strings.EqualFold(fieldName, r.Names.Original+"arn")
 }
 
+// IsSecretField returns true if the supplied field *path* refers to a Field
+// that is a SecretKeyReference
+func (r *CRD) IsSecretField(path string) bool {
+	fConfigs := r.cfg.ResourceFields(r.Names.Original)
+	fConfig, found := fConfigs[path]
+	if found {
+		return fConfig.IsSecret
+	}
+	return false
+}
+
 // SetOutputCustomMethodName returns custom set output operation as *string for
 // given operation on custom resource, if specified in generator config
 func (r *CRD) SetOutputCustomMethodName(