fix(omitUnchangedFields): only generate delta comparison check for spec fields (#476)

Skips the code generation of delta comparison check triggered by the use of the `omit_unchanged_fields:` field, if the field in question comes from the resource's `Status`. Such fields should always be included in the request, even with negative delta.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Author: marcdavoli

pkg/generate/code/set_sdk.go

@@ -313,7 +313,7 @@ func SetSDK(
 		// }
 
 		omitUnchangedFieldsOnUpdate := op == r.Ops.Update && r.OmitUnchangedFieldsOnUpdate()
-		if omitUnchangedFieldsOnUpdate {
+		if omitUnchangedFieldsOnUpdate && inSpec {
 			fieldJSONPath := fmt.Sprintf("%s.%s", cfg.PrefixConfig.SpecField[1:], f.Names.Camel)
 			out += fmt.Sprintf(
 				"%sif delta.DifferentAt(%q) {\n", indent, fieldJSONPath,
@@ -384,7 +384,7 @@ func SetSDK(
 			"%s}\n", indent,
 		)
 
-		if omitUnchangedFieldsOnUpdate {
+		if omitUnchangedFieldsOnUpdate && inSpec {
 			// decrease indentation level
 			indentLevel--
 			indent = indent[1:]

pkg/generate/code/set_sdk_test.go

@@ -1387,10 +1387,8 @@ func TestSetSDK_MQ_Broker_newUpdateRequest_OmitUnchangedValues(t *testing.T) {
 			res.SetAutoMinorVersionUpgrade(*r.ko.Spec.AutoMinorVersionUpgrade)
 		}
 	}
-	if delta.DifferentAt("Spec.BrokerID") {
-		if r.ko.Status.BrokerID != nil {
-			res.SetBrokerId(*r.ko.Status.BrokerID)
-		}
+	if r.ko.Status.BrokerID != nil {
+		res.SetBrokerId(*r.ko.Status.BrokerID)
 	}
 	if delta.DifferentAt("Spec.Configuration") {
 		if r.ko.Spec.Configuration != nil {