Resolve references hooks (#294)

Issue #, if available: aws-controllers-k8s/community#1180

Description of changes:
* This patch adds support for two custom hooks "pre_resolve_references" and "post_resolve_references"
* These hooks are needed to support TargetRef inside APIGatewayv2 Route resource where "integrations/" prefix is added before the referred IntegrationID.
* This patch also sets ResourceSynced condition to false when LateInitialization fails. This will help remove custom ResourceSynced condition handling inside `reconciler.go`

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Author: vijtrip2

pkg/generate/ack/hook.go

@@ -61,6 +61,8 @@ code paths:
 * delta_post_compare
 * late_initialize_pre_read_one
 * late_initialize_post_read_one
+* references_pre_resolve
+* references_post_resolve
 
 The "pre_build_request" hooks are called BEFORE the call to construct
 the Input shape that is used in the API operation and therefore BEFORE
@@ -110,6 +112,13 @@ readOne call inside AWSResourceManager.LateInitialize() method
 The "late_initialize_post_read_one" hooks are called AFTER making the
 readOne call inside AWSResourceManager.LateInitialize() method
 
+The "references_pre_resolve" hooks are called BEFORE resolving the
+references for all Reference fields inside AWSResourceManager.ResolveReferences()
+method
+
+The "references_post_resolve" hooks are called AFTER resolving the
+references for all Reference fields inside AWSResourceManager.ResolveReferences()
+method
 */
 
 // ResourceHookCode returns a string with custom callback code for a resource

templates/pkg/resource/manager.go.tpl

@@ -201,6 +201,7 @@ func (rm *resourceManager) LateInitialize(
 		lateInitConditionMessage = "Unable to complete Read operation required for late initialization"
 		lateInitConditionReason = "Late Initialization Failure"
 		ackcondition.SetLateInitialized(latestCopy, corev1.ConditionFalse, &lateInitConditionMessage, &lateInitConditionReason)
+		ackcondition.SetSynced(latestCopy, corev1.ConditionFalse, nil, nil)
 		return latestCopy, err
 	}
 {{- if $hookCode := Hook .CRD "late_initialize_post_read_one" }}
@@ -213,6 +214,7 @@ func (rm *resourceManager) LateInitialize(
 		lateInitConditionMessage = "Late initialization did not complete, requeuing with delay of 5 seconds"
 		lateInitConditionReason = "Delayed Late Initialization"
 		ackcondition.SetLateInitialized(lateInitializedRes, corev1.ConditionFalse, &lateInitConditionMessage, &lateInitConditionReason)
+		ackcondition.SetSynced(lateInitializedRes, corev1.ConditionFalse, nil, nil)
 		return lateInitializedRes, ackrequeue.NeededAfter(nil, time.Duration(5)*time.Second)
 	}
 	// Set LateInitialized condition to True

templates/pkg/resource/references.go.tpl

@@ -59,13 +59,19 @@ func (rm *resourceManager) ResolveReferences(
 	namespace := res.MetaObject().GetNamespace()
 	ko := rm.concreteResource(res).ko.DeepCopy()
 	err := validateReferenceFields(ko)
+{{- if $hookCode := Hook .CRD "references_pre_resolve" }}
+{{ $hookCode }}
+{{- end }}
 	{{ range $fieldName, $field := .CRD.Fields -}}
 	{{ if $field.HasReference -}}
 	if err == nil {
 		err = resolveReferenceFor{{ $field.Names.Camel }}(ctx, apiReader, namespace, ko)
 	}
 	{{ end -}}
 	{{ end -}}
+{{- if $hookCode := Hook .CRD "references_post_resolve" }}
+{{ $hookCode }}
+{{- end }}
 	if hasNonNilReferences(ko) {
 		return ackcondition.WithReferencesResolvedCondition(&resource{ko}, err)
 	}