release script and helm bug fixes (#141)

- cluster role and role binding name mismatch
- update controller image location to official public repository

Tested by creating sagemaker controller

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Author: surajkota

pkg/generate/ack/release.go

@@ -23,6 +23,7 @@ import (
 
 var (
 	releaseTemplatePaths = []string{
+		"helm/templates/cluster-role-binding.yaml.tpl",
 		"helm/Chart.yaml.tpl",
 		"helm/values.yaml.tpl",
 		"helm/templates/role-reader.yaml.tpl",
@@ -31,7 +32,6 @@ var (
 	releaseIncludePaths = []string{}
 	releaseCopyPaths    = []string{
 		"helm/templates/_helpers.tpl",
-		"helm/templates/cluster-role-binding.yaml",
 		"helm/templates/deployment.yaml",
 		"helm/templates/metrics-service.yaml",
 		"helm/templates/service-account.yaml",

scripts/build-controller-release.sh

@@ -79,7 +79,7 @@ Environment variables:
                                         Default: services/{SERVICE}
   ACK_GENERATE_IMAGE_REPOSITORY:        Specify a Docker image repository to use
                                         for release artifacts
-                                        Default: public.ecr.aws/u2r4f3v7/{SERVICE}-controller
+                                        Default: public.ecr.aws/aws-controllers-k8s/{SERVICE}-controller
   ACK_GENERATE_SERVICE_ACCOUNT_NAME:    Name of the Kubernetes Service Account and
                                         Cluster Role to use in Helm chart.
                                         Default: $ACK_GENERATE_SERVICE_ACCOUNT_NAME
@@ -121,8 +121,7 @@ SERVICE=$(echo "$1" | tr '[:upper:]' '[:lower:]')
 DEFAULT_SERVICE_CONTROLLER_SOURCE_PATH="$ROOT_DIR/../$SERVICE-controller"
 SERVICE_CONTROLLER_SOURCE_PATH=${SERVICE_CONTROLLER_SOURCE_PATH:-$DEFAULT_SERVICE_CONTROLLER_SOURCE_PATH}
 
-# TODO(vijat@): replace "u2r4f3v7" with aws-controllers-k8s
-DEFAULT_IMAGE_REPOSITORY="public.ecr.aws/u2r4f3v7/$SERVICE-controller"
+DEFAULT_IMAGE_REPOSITORY="public.ecr.aws/aws-controllers-k8s/$SERVICE-controller"
 ACK_GENERATE_IMAGE_REPOSITORY=${ACK_GENERATE_IMAGE_REPOSITORY:-"$DEFAULT_IMAGE_REPOSITORY"}
 
 if [[ ! -d $SERVICE_CONTROLLER_SOURCE_PATH ]]; then

templates/helm/templates/cluster-role-binding.yaml

@@ -0,0 +1,12 @@
+apiVersion: rbac.authorization.k8s.io/v1
+kind: ClusterRoleBinding
+metadata:
+  name: {{ "{{ include \"app.fullname\" . }}" }}
+roleRef:
+  apiGroup: rbac.authorization.k8s.io
+  kind: ClusterRole
+  name: ack-{{ .ServiceIDClean }}-controller
+subjects:
+- kind: ServiceAccount
+  name: {{ "{{ include \"service-account.name\" . }}" }}
+  namespace: {{ "{{ .Release.Namespace }}" }}