Remove subnet UserIDGroupPairs.GroupID references (#192)

a-hilaly · web-flow · commit 63881fe7c001 · 2024-05-31T07:14:51.000Z
Partial revert of cd75ad9 Initially our intention was to generate code to reference for both `GroupName` and `GroupID` fields in the `UserIDGroupPairs`. However what we (I) missed was that the code-generator processes the references fields, omits "ID" and "Name" name fields, and infers names for the referenced fields (e.g `GroupName` -> `GroupRef` and `GroupID` -> `GroupRef`. This confused the ACK code generator since both `GroupName` and `GroupID` needed a reference field called `GroupRef`. This caused some confusion at the code generation level, triggering some validation issues and introduced a regression in our references code. In a attempt to address the regression, we will first omit one of the references (GroupID), regenerate the code and address this in the code-generator later on. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
diff --git a/apis/v1alpha1/ack-generate-metadata.yaml b/apis/v1alpha1/ack-generate-metadata.yaml
@@ -1,13 +1,13 @@
 ack_generate_info:
-  build_date: "2024-05-22T16:42:26Z"
+  build_date: "2024-05-31T06:34:31Z"
   build_hash: 14cef51778d471698018b6c38b604181a6948248
-  go_version: go1.21.1
+  go_version: go1.22.3
   version: v0.34.0
-api_directory_checksum: 1b53401670898ce50e6d6cc8bfba6b63ea7d5683
+api_directory_checksum: 7fd395ceb7d5d8e35906991c7348d3498f384741
 api_version: v1alpha1
 aws_sdk_go_version: v1.44.93
 generator_config_info:
-  file_checksum: 75820b9d685b38976cd9723a9435f119ab913245
+  file_checksum: ae36cc7af80031c6de1461fa5fafad17631dbc99
   original_file_name: generator.yaml
 last_modification:
   reason: API generation
diff --git a/apis/v1alpha1/generator.yaml b/apis/v1alpha1/generator.yaml
@@ -552,10 +552,6 @@ resources:
         references:
           resource: VPC
           path: Status.VPCID
-      IngressRules.UserIDGroupPairs.GroupID:
-        references:
-          resource: SecurityGroup
-          path: Status.ID
       IngressRules.UserIDGroupPairs.GroupName:
         references:
           resource: SecurityGroup
diff --git a/generator.yaml b/generator.yaml
@@ -552,10 +552,6 @@ resources:
         references:
           resource: VPC
           path: Status.VPCID
-      IngressRules.UserIDGroupPairs.GroupID:
-        references:
-          resource: SecurityGroup
-          path: Status.ID
       IngressRules.UserIDGroupPairs.GroupName:
         references:
           resource: SecurityGroup
diff --git a/pkg/resource/security_group/references.go b/pkg/resource/security_group/references.go
