Refactor and uniform tags comparison/update logic (#196)

Fixes aws-controllers-k8s/community#2063

During the early days of ACK, the ec2 controller didn't have a lot of CRDs and most of the work around tag handling was some sort of copy/pasta from resource to resource. Time passed and now ec2-controller has 15 resources each with a slightly different tags handling implementations - making it very hard for us to maintain and bug fix if something goes wrong.

This patch does a few things to simplify the life of an ACK developer:
- Moves a lot of the tags handling logic into a single, simple and maintainable package (`pkg/tags`).
- Rely back on generated tags delta computation (back then this wasn't supported)
- Add type safety around the algorithm that was used to compare two array slices.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Author: a-hilaly

apis/v1alpha1/ack-generate-metadata.yaml

@@ -1,13 +1,13 @@
 ack_generate_info:
-  build_date: "2024-06-03T07:09:57Z"
+  build_date: "2024-06-04T06:39:17Z"
   build_hash: 14cef51778d471698018b6c38b604181a6948248
   go_version: go1.22.3
   version: v0.34.0
 api_directory_checksum: 7fd395ceb7d5d8e35906991c7348d3498f384741
 api_version: v1alpha1
 aws_sdk_go_version: v1.44.93
 generator_config_info:
-  file_checksum: b38071cec6cdb8156420ad489b68841fd9b30726
+  file_checksum: 50dfb186094519e9534c5774690536b3e2474428
   original_file_name: generator.yaml
 last_modification:
   reason: API generation

apis/v1alpha1/generator.yaml

@@ -241,11 +241,7 @@ resources:
         from:
           operation: CreateTags
           path: Tags
-        compare:
-          is_ignored: True
     hooks:
-      delta_pre_compare:
-        code: compareTags(delta, a, b)
       sdk_create_post_build_request:
         template_path: hooks/dhcp_options/sdk_create_post_build_request.go.tpl
       sdk_create_post_set_output:
@@ -277,11 +273,7 @@ resources:
         from:
           operation: CreateTags
           path: Tags
-        compare:
-          is_ignored: True
     hooks:
-      delta_pre_compare:
-        code: compareTags(delta, a, b)
       sdk_create_post_build_request:
         template_path: hooks/instance/sdk_create_post_build_request.go.tpl
       sdk_create_post_set_output:
@@ -311,14 +303,10 @@ resources:
         from:
           operation: CreateTags
           path: Tags
-        compare:
-          is_ignored: True
     list_operation:
       match_fields:
       - AllocationId
     hooks:
-      delta_pre_compare:
-        code: compareTags(delta, a, b)
       sdk_create_post_build_request:
         template_path: hooks/elastic_ip_address/sdk_create_post_build_request.go.tpl
       sdk_delete_post_build_request:
@@ -348,11 +336,7 @@ resources:
         from:
           operation: CreateTags
           path: Tags
-        compare:
-          is_ignored: True
     hooks:
-      delta_pre_compare:
-        code: compareTags(delta, a, b)
       sdk_create_post_build_request:
         template_path: hooks/flow_log/sdk_create_post_build_request.go.tpl
       sdk_create_post_set_output:
@@ -375,8 +359,6 @@ resources:
         from:
           operation: CreateTags
           path: Tags
-        compare:
-          is_ignored: True
       VPC:
         from:
           operation: AttachInternetGateway
@@ -395,8 +377,6 @@ resources:
           path: Status.internetGatewayID
           name: ID
     hooks:
-      delta_pre_compare:
-        code: compareTags(delta, a, b)
       sdk_create_post_build_request:
         template_path: hooks/internet_gateway/sdk_create_post_build_request.go.tpl
       sdk_create_post_set_output:
@@ -436,16 +416,12 @@ resources:
         from:
           operation: CreateTags
           path: Tags
-        compare:
-          is_ignored: True
     synced:
       when:
       - path: Status.State
         in:
         - available
     hooks:
-      delta_pre_compare:
-        code: compareTags(delta, a, b)
       sdk_create_post_build_request:
         template_path: hooks/nat_gateway/sdk_create_post_build_request.go.tpl
       sdk_file_end:
@@ -479,8 +455,6 @@ resources:
         from:
           operation: CreateTags
           path: Tags
-        compare:
-          is_ignored: True
       VpcId:
         references:
           resource: VPC
@@ -541,8 +515,6 @@ resources:
         from:
           operation: CreateTags
           path: Tags
-        compare:
-          is_ignored: True
       VpcId:
         is_required: true
         references:
@@ -573,8 +545,6 @@ resources:
             GroupIds: Ids
             GroupNames: Names
     hooks:
-      delta_pre_compare:
-        code: compareTags(delta, a, b)
       sdk_create_post_build_request:
         template_path: hooks/security_group/sdk_create_post_build_request.go.tpl
       sdk_file_end:
@@ -603,8 +573,6 @@ resources:
         from:
           operation: CreateTags
           path: Tags
-        compare:
-          is_ignored: True
       VpcId:
         is_required: true
         references:
@@ -632,8 +600,6 @@ resources:
           input_fields:
             NetworkAclId: Id    
     hooks:
-      delta_pre_compare:
-        code: compareTags(delta, a, b)
       sdk_create_post_build_request:
         template_path: hooks/network_acl/sdk_create_post_build_request.go.tpl
       sdk_file_end:
@@ -682,8 +648,6 @@ resources:
         from:
           operation: CreateTags
           path: Tags
-        compare:
-          is_ignored: True
       VpcId:
         references:
           resource: VPC
@@ -693,8 +657,6 @@ resources:
         - InvalidParameterValue
         - InvalidCustomerOwnedIpv4PoolID.Malformed
     hooks:
-      delta_pre_compare:
-        code: compareTags(delta, a, b)
       sdk_create_post_build_request:
         template_path: hooks/subnet/sdk_create_post_build_request.go.tpl
       sdk_create_post_set_output:
@@ -711,8 +673,6 @@ resources:
         from:
           operation: CreateTags
           path: Tags
-        compare:
-          is_ignored: True
       State:
         print:
           path: Status.state
@@ -722,8 +682,6 @@ resources:
           path: Status.transitGatewayID
           name: ID
     hooks:
-      delta_pre_compare:
-        code: compareTags(delta, a, b)
       sdk_create_post_build_request:
         template_path: hooks/transit_gateway/sdk_create_post_build_request.go.tpl
       sdk_file_end:
@@ -760,15 +718,11 @@ resources:
         from:
           operation: CreateTags
           path: Tags
-        compare:
-          is_ignored: True
       VpcID:
         print:
           path: Status.vpcID
           name: ID
     hooks:
-      delta_pre_compare:
-        code: compareTags(delta, a, b)
       sdk_create_post_build_request:
         template_path: hooks/vpc/sdk_create_post_build_request.go.tpl
       sdk_create_post_set_output:
@@ -785,8 +739,6 @@ resources:
         from:
           operation: CreateTags
           path: Tags
-        compare:
-          is_ignored: True
       VpcId:
         references:
           resource: VPC
@@ -816,8 +768,6 @@ resources:
         - InvalidVpcId.Malformed
         - InvalidServiceName
     hooks:
-      delta_pre_compare:
-        code: compareTags(delta, a, b)
       sdk_create_post_build_request:
         template_path: hooks/vpc_endpoint/sdk_create_post_build_request.go.tpl
       sdk_create_post_set_output:
@@ -851,16 +801,12 @@ resources:
         from:
           operation: CreateTags
           path: Tags
-        compare:
-          is_ignored: true
     synced:
       when:
       - path: Status.ServiceState
         in:
         - available
     hooks:
-      delta_pre_compare:
-        code: compareTags(delta, a, b)
       sdk_delete_post_build_request:
         template_path: hooks/vpc_endpoint_service_configuration/sdk_delete_post_build_request.go.tpl
       sdk_file_end:
@@ -893,11 +839,7 @@ resources:
         from:
           operation: CreateTags
           path: Tags
-        compare:
-          is_ignored: True
     hooks:
-      delta_pre_compare:
-        code: compareTags(delta, a, b)
       sdk_create_post_build_request:
         template_path: hooks/vpc_peering_connection/sdk_create_post_build_request.go.tpl
       sdk_create_post_set_output: