Skip to content

Commit 060d432

Browse files
Rename ReplicationGroupDescription to Description (#89)
Issue #, if available: aws-controllers-k8s/community#1250 Description of changes: Renamed the `CreateReplicationGroup` and `ModifyReplicationGroup` input field `ReplicationGroupDescription` to simply be `Description`, to match the `DescribeReplicationGroups` output shape By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
1 parent 09058ac commit 060d432

File tree

56 files changed

+131
-119
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

56 files changed

+131
-119
lines changed
Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
ack_generate_info:
2-
build_date: "2022-03-25T18:32:50Z"
3-
build_hash: c6b852a8017aa73cfc5a882b1ba60c88d820e967
4-
go_version: go1.17.5
5-
version: v0.18.1
6-
api_directory_checksum: 246af92291668493e03954b4e4117c21f5b62790
2+
build_date: "2022-04-11T23:03:51Z"
3+
build_hash: fc5620cf5fde243ee5124324d26bb7e952049bf2
4+
go_version: go1.17.8
5+
version: v0.18.3
6+
api_directory_checksum: 7087207d90a71ce286e3c45edad16bb89b0a8eb3
77
api_version: v1alpha1
88
aws_sdk_go_version: v1.42.0
99
generator_config_info:
10-
file_checksum: 4fd6f317804ecb5192bfb88c569ae335d418248b
10+
file_checksum: 2461349a2827ec98ae7440fbff3301c1effcfaf4
1111
original_file_name: generator.yaml
1212
last_modification:
1313
reason: API generation

apis/v1alpha1/generator.yaml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,14 @@ resources:
8282
template_path: hooks/replication_group/sdk_file_end.go.tpl
8383
sdk_file_end_set_output_post_populate:
8484
code: "rm.customSetOutput(obj, ko) // custom set output from obj"
85+
renames:
86+
operations:
87+
CreateReplicationGroup:
88+
input_fields:
89+
ReplicationGroupDescription: Description
90+
ModifyReplicationGroup:
91+
input_fields:
92+
ReplicationGroupDescription: Description
8593
Snapshot:
8694
update_conditions_custom_method_name: CustomUpdateConditions
8795
exceptions:

apis/v1alpha1/replication_group.go

Lines changed: 3 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apis/v1alpha1/zz_generated.deepcopy.go

Lines changed: 5 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

config/crd/bases/elasticache.services.k8s.aws_replicationgroups.yaml

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -144,6 +144,9 @@ spec:
144144
creating a cluster. For more information, see Subnets and Subnet
145145
Groups (https://docs.aws.amazon.com/AmazonElastiCache/latest/red-ug/SubnetGroups.html)."
146146
type: string
147+
description:
148+
description: A user-created description for the replication group.
149+
type: string
147150
engine:
148151
description: The name of the cache engine to be used for the clusters
149152
in this replication group. Must be Redis.
@@ -293,9 +296,6 @@ spec:
293296
nodes in each node group (shard). Valid values are 0 to 5.
294297
format: int64
295298
type: integer
296-
replicationGroupDescription:
297-
description: A user-created description for the replication group.
298-
type: string
299299
replicationGroupID:
300300
description: "The replication group identifier. This parameter is
301301
stored as a lowercase string. \n Constraints: \n * A name must
@@ -383,7 +383,7 @@ spec:
383383
type: string
384384
type: array
385385
required:
386-
- replicationGroupDescription
386+
- description
387387
- replicationGroupID
388388
type: object
389389
status:
@@ -496,9 +496,6 @@ spec:
496496
format: int64
497497
type: integer
498498
type: object
499-
description:
500-
description: The user supplied description of the replication group.
501-
type: string
502499
events:
503500
description: A list of events. Each element in the list contains detailed
504501
information about one event.

generator.yaml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,14 @@ resources:
8282
template_path: hooks/replication_group/sdk_file_end.go.tpl
8383
sdk_file_end_set_output_post_populate:
8484
code: "rm.customSetOutput(obj, ko) // custom set output from obj"
85+
renames:
86+
operations:
87+
CreateReplicationGroup:
88+
input_fields:
89+
ReplicationGroupDescription: Description
90+
ModifyReplicationGroup:
91+
input_fields:
92+
ReplicationGroupDescription: Description
8593
Snapshot:
8694
update_conditions_custom_method_name: CustomUpdateConditions
8795
exceptions:

go.local.mod

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,8 @@ require (
3434
github.com/google/uuid v1.1.2 // indirect
3535
github.com/googleapis/gnostic v0.5.5 // indirect
3636
github.com/imdario/mergo v0.3.12 // indirect
37+
github.com/itchyny/gojq v0.12.6 // indirect
38+
github.com/itchyny/timefmt-go v0.1.3 // indirect
3739
github.com/jaypipes/envutil v1.0.0 // indirect
3840
github.com/jmespath/go-jmespath v0.4.0 // indirect
3941
github.com/json-iterator/go v1.1.12 // indirect
@@ -50,7 +52,7 @@ require (
5052
go.uber.org/multierr v1.6.0 // indirect
5153
golang.org/x/net v0.0.0-20210825183410-e898025ed96a // indirect
5254
golang.org/x/oauth2 v0.0.0-20210819190943-2bc19b11175f // indirect
53-
golang.org/x/sys v0.0.0-20211029165221-6e7872819dc8 // indirect
55+
golang.org/x/sys v0.0.0-20211124211545-fe61309f8881 // indirect
5456
golang.org/x/term v0.0.0-20210615171337-6886f2dfbf5b // indirect
5557
golang.org/x/text v0.3.7 // indirect
5658
golang.org/x/time v0.0.0-20210723032227-1f47c861a9ac // indirect

helm/crds/elasticache.services.k8s.aws_replicationgroups.yaml

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -144,6 +144,9 @@ spec:
144144
creating a cluster. For more information, see Subnets and Subnet
145145
Groups (https://docs.aws.amazon.com/AmazonElastiCache/latest/red-ug/SubnetGroups.html)."
146146
type: string
147+
description:
148+
description: A user-created description for the replication group.
149+
type: string
147150
engine:
148151
description: The name of the cache engine to be used for the clusters
149152
in this replication group. Must be Redis.
@@ -293,9 +296,6 @@ spec:
293296
nodes in each node group (shard). Valid values are 0 to 5.
294297
format: int64
295298
type: integer
296-
replicationGroupDescription:
297-
description: A user-created description for the replication group.
298-
type: string
299299
replicationGroupID:
300300
description: "The replication group identifier. This parameter is
301301
stored as a lowercase string. \n Constraints: \n * A name must
@@ -383,7 +383,7 @@ spec:
383383
type: string
384384
type: array
385385
required:
386-
- replicationGroupDescription
386+
- description
387387
- replicationGroupID
388388
type: object
389389
status:
@@ -496,9 +496,6 @@ spec:
496496
format: int64
497497
type: integer
498498
type: object
499-
description:
500-
description: The user supplied description of the replication group.
501-
type: string
502499
events:
503500
description: A list of events. Each element in the list contains detailed
504501
information about one event.

pkg/resource/cache_parameter_group/sdk.go

Lines changed: 4 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/resource/cache_subnet_group/sdk.go

Lines changed: 4 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)