Support Bucket versioning (#34)

Support creating and updating `VersioningConfiguration` for Buckets.

I have disabled the `MFADelete` field path. [Configuring MFA Delete](https://docs.aws.amazon.com/AmazonS3/latest/userguide/MultiFactorAuthenticationDelete.html) requires that users include an MFA token along with any subsequent requests to disable bucket versioning. Since the controllers do not support MFA authentication, setting this option would block the user from changing versioning after the fact.

Author: RedbackThomson

apis/v1alpha1/ack-generate-metadata.yaml

@@ -1,14 +1,14 @@
 ack_generate_info:
-  build_date: "2021-08-11T18:08:42Z"
-  build_hash: 605d747a4da2a01ec3a25fb67a271291f529e810
+  build_date: "2021-08-12T22:22:41Z"
+  build_hash: 4d0db1b6f794e5221eb88b052b52a1a95017cf20
   go_version: go1.15.6 linux/amd64
   version: v0.9.2
-api_directory_checksum: 78ef91732ff85b6e22c35d0b1bd5a1211aad02d8
+api_directory_checksum: a111b8798ffa13b2cf948befafae28feaef463ab
 api_version: v1alpha1
 aws_sdk_go_version: v1.37.10
 generator_config_info:
-  file_checksum: ded17f6f1ac538a0e908d4198303253514bcb5aa
+  file_checksum: 85625c1a8af87eb3bbda9c6764a356bd3751cb31
   original_file_name: generator.yaml
 last_modification:
   reason: API generation
-  timestamp: 2021-08-11 18:08:48.788384628 +0000 UTC
+  timestamp: 2021-08-12 22:22:48.65031987 +0000 UTC

apis/v1alpha1/bucket.go

@@ -5,6 +5,9 @@ ignore:
   shape_names:
     # These shapes are structs with no members...
     - SSES3
+  field_paths:
+    # We cannot support MFA, so if it is set we cannot unset
+    - "VersioningConfiguration.MFADelete"
 operations:
   ListBuckets:
     primary_identifier_field_name: Name
@@ -71,10 +74,10 @@ resources:
         from:
           operation: PutBucketTagging
           path: Tagging
-      # Versioning:
-      #   from:
-      #     operation: PutBucketVersioning
-      #     path: VersioningConfiguration # Double check about MFA
+      Versioning:
+        from:
+          operation: PutBucketVersioning
+          path: VersioningConfiguration
       Website:
         from:
           operation: PutBucketWebsite

apis/v1alpha1/generator.yaml

@@ -214,6 +214,12 @@ spec:
                       type: object
                     type: array
                 type: object
+              versioning:
+                description: Container for setting the versioning state.
+                properties:
+                  status:
+                    type: string
+                type: object
               website:
                 description: Container for the request.
                 properties:

apis/v1alpha1/types.go

@@ -5,6 +5,9 @@ ignore:
   shape_names:
     # These shapes are structs with no members...
     - SSES3
+  field_paths:
+    # We cannot support MFA, so if it is set we cannot unset
+    - "VersioningConfiguration.MFADelete"
 operations:
   ListBuckets:
     primary_identifier_field_name: Name
@@ -71,10 +74,10 @@ resources:
         from:
           operation: PutBucketTagging
           path: Tagging
-      # Versioning:
-      #   from:
-      #     operation: PutBucketVersioning
-      #     path: VersioningConfiguration # Double check about MFA
+      Versioning:
+        from:
+          operation: PutBucketVersioning
+          path: VersioningConfiguration
       Website:
         from:
           operation: PutBucketWebsite

apis/v1alpha1/zz_generated.deepcopy.go

@@ -25,8 +25,9 @@ import (
 )
 
 var (
-	DefaultAccelerationConfigurationStatus = "Suspended"
-	DefaultRequestPayer                    = "BucketOwner"
+	DefaultAccelerationConfigurationStatus = svcsdk.BucketAccelerateStatusSuspended
+	DefaultRequestPayer                    = svcsdk.PayerBucketOwner
+	DefaultVersioningStatus                = svcsdk.BucketVersioningStatusSuspended
 )
 
 var (
@@ -72,6 +73,11 @@ func (rm *resourceManager) createPutFields(
 			return err
 		}
 	}
+	if r.ko.Spec.Versioning != nil {
+		if err := rm.syncVersioning(ctx, r); err != nil {
+			return err
+		}
+	}
 	if r.ko.Spec.Website != nil {
 		if err := rm.syncWebsite(ctx, r); err != nil {
 			return err
@@ -143,6 +149,11 @@ func (rm *resourceManager) customUpdateBucket(
 			return nil, err
 		}
 	}
+	if delta.DifferentAt("Spec.Versioning") {
+		if err := rm.syncVersioning(ctx, desired); err != nil {
+			return nil, err
+		}
+	}
 	if delta.DifferentAt("Spec.Website") {
 		if err := rm.syncWebsite(ctx, desired); err != nil {
 			return nil, err
@@ -227,6 +238,12 @@ func (rm *resourceManager) addPutFieldsToSpec(
 	}
 	ko.Spec.Tagging = rm.setResourceTagging(r, getTaggingResponse)
 
+	getVersioningResponse, err := rm.sdkapi.GetBucketVersioningWithContext(ctx, rm.newGetBucketVersioningPayload(r))
+	if err != nil {
+		return err
+	}
+	ko.Spec.Versioning = rm.setResourceVersioning(r, getVersioningResponse)
+
 	getWebsiteResponse, err := rm.sdkapi.GetBucketWebsiteWithContext(ctx, rm.newGetBucketWebsitePayload(r))
 	if err != nil {
 		if awsErr, ok := ackerr.AWSError(err); ok && awsErr.Code() == "NoSuchWebsiteConfiguration" {
@@ -297,6 +314,11 @@ func customPreCompare(
 	if a.ko.Spec.Tagging == nil && b.ko.Spec.Tagging != nil {
 		a.ko.Spec.Tagging = &svcapitypes.Tagging{}
 	}
+	if a.ko.Spec.Versioning == nil && b.ko.Spec.Versioning != nil {
+		a.ko.Spec.Versioning = &svcapitypes.VersioningConfiguration{
+			Status: &DefaultVersioningStatus,
+		}
+	}
 	if a.ko.Spec.Website == nil && b.ko.Spec.Website != nil {
 		a.ko.Spec.Website = &svcapitypes.WebsiteConfiguration{}
 	}
@@ -658,6 +680,50 @@ func (rm *resourceManager) syncTagging(
 	return nil
 }
 
+func (rm *resourceManager) newGetBucketVersioningPayload(
+	r *resource,
+) *svcsdk.GetBucketVersioningInput {
+	res := &svcsdk.GetBucketVersioningInput{}
+	res.SetBucket(*r.ko.Spec.Name)
+	return res
+}
+
+func (rm *resourceManager) newPutBucketVersioningPayload(
+	r *resource,
+) *svcsdk.PutBucketVersioningInput {
+	res := &svcsdk.PutBucketVersioningInput{}
+	res.SetBucket(*r.ko.Spec.Name)
+	if r.ko.Spec.Versioning != nil {
+		res.SetVersioningConfiguration(rm.newVersioningConfiguration(r))
+	} else {
+		res.SetVersioningConfiguration(&svcsdk.VersioningConfiguration{})
+	}
+
+	if res.VersioningConfiguration.Status == nil {
+		res.VersioningConfiguration.SetStatus(DefaultVersioningStatus)
+	}
+
+	return res
+}
+
+func (rm *resourceManager) syncVersioning(
+	ctx context.Context,
+	r *resource,
+) (err error) {
+	rlog := ackrtlog.FromContext(ctx)
+	exit := rlog.Trace("rm.syncVersioning")
+	defer exit(err)
+	input := rm.newPutBucketVersioningPayload(r)
+
+	_, err = rm.sdkapi.PutBucketVersioningWithContext(ctx, input)
+	rm.metrics.RecordAPICall("UPDATE", "PutBucketVersioning", err)
+	if err != nil {
+		return err
+	}
+
+	return nil
+}
+
 func (rm *resourceManager) newGetBucketWebsitePayload(
 	r *resource,
 ) *svcsdk.GetBucketWebsiteInput {