Commit 9adb770
authored
bring controller to rt 0.20.1 and sdk 1.44.93 (#89)
The S3 controller was not successfully being generated with ACK
runtime v0.20.1. An error was being thrown during deepcopy-gen. Turns
out that aws-sdk-go v1.44.93, which was brought in because it is used for
latest code-generator, added a few fields to the S3 Bucket. One of these
fields is `NotificationConfiguration.EventBridgeConfiguration` and it is an
empty struct with no fields. Looks like S3 team just added it into the API
model without finishing the thought... anyway, ignoring this field in the
generator.yaml file enabled the code-generator to successfully complete.
Signed-off-by: Jay Pipes <jaypipes@gmail.com>
Issue aws-controllers-k8s/community#1475
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.1 parent 01c6f0a commit 9adb770
File tree
19 files changed
+351
-139
lines changed- apis/v1alpha1
- config
- crd/bases
- rbac
- helm
- crds
- templates
- pkg/resource/bucket
19 files changed
+351
-139
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
3 | | - | |
4 | | - | |
5 | | - | |
6 | | - | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
| 12 | + | |
11 | 13 | | |
12 | 14 | | |
13 | 15 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments