Move RAM services association resources local to data.tf

Author: JakubCzarniecki

data.tf

@@ -43,6 +43,19 @@ locals {
   share_service_network = local.config_ram_share ? local.create_service_network && try(var.ram_share.share_service_network, true) : false
   # Default of var.ram_share.share_services - if not defined, all the created services will be included
   share_services = try(var.ram_share.share_services, keys(var.services))
+  # Support RAM share of services managed by the module as well as external ones
+  ram_services_association_resources = {
+    for svc in local.share_services :
+    svc => lookup(
+      aws_vpclattice_service.lattice_service,
+      svc,
+      lookup(
+        data.aws_vpclattice_service.lattice_service,
+        svc,
+        null
+      )
+    )
+  }
   # Move var.ram_share.principals from list(string) to map(string)
   principals_map = { for index, principal in try(var.ram_share.principals, []) : index => principal }
 }

main.tf

@@ -274,21 +274,6 @@ resource "aws_ram_resource_association" "ram_service_network_association" {
   resource_share_arn = local.resource_share_arn
 }
 
-locals {
-  ram_services_association_resources = {
-    for svc in local.share_services :
-    svc => lookup(
-      aws_vpclattice_service.lattice_service,
-      svc,
-      lookup(
-        data.aws_vpclattice_service.lattice_service,
-        svc,
-        null
-      )
-    )
-  }
-}
-
 # AWS RAM resource association - VPC Lattice services
 resource "aws_ram_resource_association" "ram_services_association" {
   count = local.config_ram_share ? length(local.share_services) : 0