Skip to content

Commit 161ccd6

Browse files
committed
Updated change log to include changes, pyproject.toml dependency updates
1 parent ca16906 commit 161ccd6

File tree

4 files changed

+279
-145
lines changed

4 files changed

+279
-145
lines changed

CHANGELOG.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
## Table of Contents<!-- omit in toc -->
44

55
- [Introduction](#introduction)
6+
- [2022-07-12](#2022-07-12)
67
- [2022-05-23](#2022-05-23)
78
- [2022-05-15](#2022-05-15)
89
- [2022-04-25](#2022-04-25)
@@ -29,6 +30,14 @@ All notable changes to this project will be documented in this file.
2930

3031
---
3132

33+
## 2022-07-12
34+
35+
### Changed<!-- omit in toc -->
36+
37+
- Added Checkov Lambda Function suppressions for CKV_AWS_115 (Reserved Concurrent Executions) and CKV_AWS_117 (Run within a VPC) to all solution templates with Lambda Function configurations.
38+
- Updated the [customizations-for-aws-control-tower.template](aws_sra_examples/solutions/common/common_cfct_setup/templates/customizations-for-aws-control-tower.template) to the latest version v2.4.0 and added Checkov suppressions.
39+
- Updated pyproject.toml dependencies to the latest versions.
40+
3241
## 2022-05-23
3342

3443
### Changed<!-- omit in toc -->

aws_sra_examples/solutions/common/common_cfct_setup/templates/customizations-for-aws-control-tower.template

Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -255,6 +255,10 @@ Resources:
255255
rules_to_suppress:
256256
- id: W35
257257
reason: "This S3 bucket is used as the destination for 'CustomControlTowerPipelineS3Bucket' and 'CustomControlTowerPipelineArtifactS3Bucket'"
258+
checkov:
259+
skip:
260+
- id: CKV_AWS_18
261+
comment: S3 access logging is not enabled.
258262
Properties:
259263
AccessControl: LogDeliveryWrite
260264
VersioningConfiguration:
@@ -490,6 +494,10 @@ Resources:
490494
rules_to_suppress:
491495
- id: W11
492496
reason: "Allow Resource * for Cloudformation/SSM API: needs to support user defined cfn templates and ssm parameter names."
497+
checkov:
498+
skip:
499+
- id: CKV_AWS_108
500+
comment: "Allow Resource * for Cloudformation/SSM API: needs to support user defined cfn templates and ssm parameter names."
493501
Properties:
494502
AssumeRolePolicyDocument:
495503
Version: "2012-10-17"
@@ -997,6 +1005,16 @@ Resources:
9971005
reason: "This lambda function does not need access to VPC resources"
9981006
- id: W92
9991007
reason: "This use case does not need to set the ReservedConcurrentExecutions"
1008+
checkov:
1009+
skip:
1010+
- id: CKV_AWS_115
1011+
comment: Lambda does not need reserved concurrent executions.
1012+
- id: CKV_AWS_116
1013+
comment: DLQ not needed, as Lambda function only triggered by CloudFormation events.
1014+
- id: CKV_AWS_117
1015+
comment: Lambda does not need to communicate with VPC resources.
1016+
- id: CKV_AWS_173
1017+
comment: Environment variables are not sensitive
10001018
Properties:
10011019
Environment:
10021020
Variables:
@@ -1090,6 +1108,14 @@ Resources:
10901108
reason: "The role name is defined to identify Custom Control Tower resources."
10911109
- id: W11
10921110
reason: "Allow Resource * for KMS/SSM/Org/SC/CFN API. Key ID is generated by the service. Other resources are customer defined."
1111+
checkov:
1112+
skip:
1113+
- id: CKV_AWS_108
1114+
comment: "Allow Resource * for KMS/SSM/Org/SC/CFN API. Key ID is generated by the service. Other resources are customer defined."
1115+
- id: CKV_AWS_109
1116+
comment: "Allow Resource * for KMS/SSM/Org/SC/CFN API. Key ID is generated by the service. Other resources are customer defined."
1117+
- id: CKV_AWS_111
1118+
comment: "Allow Resource * for KMS/SSM/Org/SC/CFN API. Key ID is generated by the service. Other resources are customer defined."
10931119
Properties:
10941120
RoleName: CustomControlTowerStateMachineLambdaRole
10951121
AssumeRolePolicyDocument:
@@ -1264,6 +1290,16 @@ Resources:
12641290
reason: "This lambda function does not need access to VPC resources"
12651291
- id: W92
12661292
reason: "This use case does not need to set the ReservedConcurrentExecutions"
1293+
checkov:
1294+
skip:
1295+
- id: CKV_AWS_115
1296+
comment: Lambda does not need reserved concurrent executions.
1297+
- id: CKV_AWS_116
1298+
comment: DLQ not needed, as Lambda function only triggered by CloudFormation events.
1299+
- id: CKV_AWS_117
1300+
comment: Lambda does not need to communicate with VPC resources.
1301+
- id: CKV_AWS_173
1302+
comment: Environment variables are not sensitive
12671303
Properties:
12681304
Environment:
12691305
Variables:
@@ -2881,6 +2917,16 @@ Resources:
28812917
reason: "This lambda function does not need access to VPC resources"
28822918
- id: W92
28832919
reason: "This use case does not need to set the ReservedConcurrentExecutions"
2920+
checkov:
2921+
skip:
2922+
- id: CKV_AWS_115
2923+
comment: Lambda does not need reserved concurrent executions.
2924+
- id: CKV_AWS_116
2925+
comment: DLQ not needed, as Lambda function only triggered by CloudFormation events.
2926+
- id: CKV_AWS_117
2927+
comment: Lambda does not need to communicate with VPC resources.
2928+
- id: CKV_AWS_173
2929+
comment: Environment variables are not sensitive
28842930
Properties:
28852931
Environment:
28862932
Variables:

0 commit comments

Comments
 (0)