fix: the total number of item attributes is limited to 10 (#44)

Author: zhu-xiaowei

Sources/Clickstream/Dependency/Clickstream/Event/EventChecker.swift

@@ -166,6 +166,7 @@ class EventChecker {
     static func checkItem(currentNumber: Int, item: ClickstreamAttribute) ->
         (eventError: EventError, resultItem: ClickstreamAttribute)
     {
+        initItemKeySet()
         var resultItem: ClickstreamAttribute = [:]
         if currentNumber >= Event.Limit.MAX_NUM_OF_ITEMS {
             let itemJsonString = (item as JsonObject).toJsonString()
@@ -253,22 +254,24 @@ class EventChecker {
     }
 
     static func initItemKeySet() {
-        itemKeySet = Set<String>([
-            ClickstreamAnalytics.Item.ITEM_ID,
-            ClickstreamAnalytics.Item.ITEM_NAME,
-            ClickstreamAnalytics.Item.LOCATION_ID,
-            ClickstreamAnalytics.Item.ITEM_BRAND,
-            ClickstreamAnalytics.Item.CURRENCY,
-            ClickstreamAnalytics.Item.PRICE,
-            ClickstreamAnalytics.Item.QUANTITY,
-            ClickstreamAnalytics.Item.CREATIVE_NAME,
-            ClickstreamAnalytics.Item.CREATIVE_SLOT,
-            ClickstreamAnalytics.Item.ITEM_CATEGORY,
-            ClickstreamAnalytics.Item.ITEM_CATEGORY2,
-            ClickstreamAnalytics.Item.ITEM_CATEGORY3,
-            ClickstreamAnalytics.Item.ITEM_CATEGORY4,
-            ClickstreamAnalytics.Item.ITEM_CATEGORY5
-        ])
+        if itemKeySet.isEmpty {
+            itemKeySet = Set<String>([
+                ClickstreamAnalytics.Item.ITEM_ID,
+                ClickstreamAnalytics.Item.ITEM_NAME,
+                ClickstreamAnalytics.Item.LOCATION_ID,
+                ClickstreamAnalytics.Item.ITEM_BRAND,
+                ClickstreamAnalytics.Item.CURRENCY,
+                ClickstreamAnalytics.Item.PRICE,
+                ClickstreamAnalytics.Item.QUANTITY,
+                ClickstreamAnalytics.Item.CREATIVE_NAME,
+                ClickstreamAnalytics.Item.CREATIVE_SLOT,
+                ClickstreamAnalytics.Item.ITEM_CATEGORY,
+                ClickstreamAnalytics.Item.ITEM_CATEGORY2,
+                ClickstreamAnalytics.Item.ITEM_CATEGORY3,
+                ClickstreamAnalytics.Item.ITEM_CATEGORY4,
+                ClickstreamAnalytics.Item.ITEM_CATEGORY5
+            ])
+        }
     }
 }
 

Tests/ClickstreamTests/Clickstream/ClickstreamEventTest.swift

@@ -113,6 +113,22 @@ class ClickstreamEventTest: XCTestCase {
         XCTAssertEqual(0, clickstreamEvent.items.count)
     }
 
+    func testAddItemPrestAndCustomAttributeNotExceedTheLimit() {
+        var item: ClickstreamAttribute = [
+            ClickstreamAnalytics.Item.ITEM_ID: 123,
+            ClickstreamAnalytics.Item.ITEM_NAME: "testName1",
+            ClickstreamAnalytics.Item.ITEM_BRAND: "Google",
+            ClickstreamAnalytics.Item.CURRENCY: "CNY",
+            ClickstreamAnalytics.Item.LOCATION_ID: "1"
+        ]
+        for i in 0 ..< 10 {
+            item["custom_attr_\(i)"] = "value_\(i)"
+        }
+        clickstreamEvent.addItem(item)
+        XCTAssertTrue(clickstreamEvent.attribute(forKey: Event.ReservedAttribute.ERROR_CODE) == nil)
+        XCTAssertEqual(1, clickstreamEvent.items.count)
+    }
+
     func testAddItemErrorForExceedMaxLengthOfAttributeName() {
         let longAttributeKey = String(repeating: "a", count: 51)
         let item: ClickstreamAttribute = [