Skip to content

Commit 70ba325

Browse files
committed
fix: disabled failing integration test temporarily due to expired credentials
1 parent 5bbd061 commit 70ba325

File tree

2 files changed

+11
-0
lines changed

2 files changed

+11
-0
lines changed

test/integration/plugin/test_credentials_providers.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,9 @@ def getAcceptedIssuers(self):
4545
# at a later time
4646
DEFAULT_CONTEXT = SSLContext.getDefault()
4747

48+
def skip_if_okta(idp_arg):
49+
if "OktaCredentialsProvider" == idp_arg["credentials_provider"]:
50+
pytest.skip("Temporarily disable the test due to expired Okta credential (Redshift-115253)")
4851

4952
@pytest.mark.parametrize("idp_arg", NON_BROWSER_IDP, indirect=True)
5053
def test_idp_password(idp_arg):
@@ -59,6 +62,7 @@ def test_idp_password(idp_arg):
5962

6063
@pytest.mark.parametrize("idp_arg", NON_BROWSER_IDP, indirect=True)
6164
def test_cluster_identifier(idp_arg):
65+
skip_if_okta(idp_arg)
6266
wrong_identifier = "redshift-cluster-11"
6367
idp_arg["cluster_identifier"] = wrong_identifier
6468

@@ -68,6 +72,7 @@ def test_cluster_identifier(idp_arg):
6872

6973
@pytest.mark.parametrize("idp_arg", NON_BROWSER_IDP, indirect=True)
7074
def test_region(idp_arg):
75+
skip_if_okta(idp_arg)
7176
wrong_region = "us-east-22"
7277
idp_arg["region"] = wrong_region
7378

@@ -80,12 +85,14 @@ def test_region(idp_arg):
8085

8186
@pytest.mark.parametrize("idp_arg", NON_BROWSER_IDP, indirect=True)
8287
def test_credentials_provider(idp_arg):
88+
skip_if_okta(idp_arg)
8389
with redshift_connector.connect(**idp_arg):
8490
pass
8591

8692

8793
@pytest.mark.parametrize("idp_arg", NON_BROWSER_IDP, indirect=True)
8894
def test_preferred_role_invalid_should_fail(idp_arg):
95+
skip_if_okta(idp_arg)
8996
idp_arg["preferred_role"] = "arn:aws:iam::111111111111:role/Trash-role"
9097
with pytest.raises(
9198
redshift_connector.InterfaceError,
@@ -110,6 +117,7 @@ def test_invalid_db_group(idp_arg):
110117
@pytest.mark.parametrize("idp_arg", ["okta_idp", "azure_idp"], indirect=True)
111118
@pytest.mark.parametrize("ssl_insecure_val", [True, False])
112119
def test_ssl_insecure_is_used(idp_arg, ssl_insecure_val):
120+
skip_if_okta(idp_arg)
113121
idp_arg["ssl_insecure"] = ssl_insecure_val
114122

115123
with redshift_connector.connect(**idp_arg):
@@ -169,6 +177,7 @@ def use_cached_temporary_credentials(idp_arg):
169177

170178
@pytest.mark.parametrize("idp_arg", NON_BROWSER_IDP, indirect=True)
171179
def test_stl_connection_log_contains_plugin_name(idp_arg, db_kwargs):
180+
skip_if_okta(idp_arg)
172181
idp_arg["auto_create"] = True
173182
with redshift_connector.connect(**idp_arg) as conn:
174183
with conn.cursor() as cursor:
@@ -211,6 +220,7 @@ def uses_db_groups_nominal(idp_arg, db_groups):
211220

212221
@pytest.mark.parametrize("idp_arg", NON_BROWSER_IDP, indirect=True)
213222
def test_connect_with_group_federation(idp_arg):
223+
skip_if_okta(idp_arg)
214224
idp_arg["group_federation"] = True
215225

216226
with redshift_connector.connect(**idp_arg):

test/integration/plugin/test_okta_credentials_provider.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ def test_idp_host_invalid_should_fail(idp_arg) -> None:
2222
redshift_connector.connect(**idp_arg)
2323

2424

25+
@pytest.mark.skip(reason="Temporarily disable the test due to expired Okta credential (Redshift-115253)")
2526
@pytest.mark.parametrize("idp_arg", PROVIDER, indirect=True)
2627
def test_preferred_role_should_use(idp_arg) -> None:
2728
idp_arg["preferred_role"] = conf.get("okta-idp", "preferred_role")

0 commit comments

Comments
 (0)