fix(idp, browser): display close window message after auth with IdP

Brooke-white · Brooke-white · commit a3374a355b4c · 2021-07-19T10:00:32.000-07:00
diff --git a/redshift_connector/plugin/browser_azure_credentials_provider.py b/redshift_connector/plugin/browser_azure_credentials_provider.py
@@ -218,7 +218,7 @@ def run_server(
 
                     if received_code == "":
                         raise InterfaceError("No valid code found")
-
+                    conn.send(self.close_window_http_resp())
                     return received_code
 
     # Opens the default browser with the authorization request to the IDP
diff --git a/redshift_connector/plugin/browser_saml_credentials_provider.py b/redshift_connector/plugin/browser_saml_credentials_provider.py
@@ -93,6 +93,7 @@ def run_server(self: "BrowserSamlCredentialsProvider", listen_port: int, idp_res
                     _logger.debug("Data received contained SAMLResponse: {}".format(bool(result is not None)))
 
                     if result is not None:
+                        conn.send(self.close_window_http_resp())
                         saml_resp_block: str = decoded_part[result.regs[0][1] :]
                         end_idx: int = saml_resp_block.find("&RelayState=")
                         if end_idx > -1:
diff --git a/redshift_connector/plugin/saml_credentials_provider.py b/redshift_connector/plugin/saml_credentials_provider.py
@@ -177,6 +177,13 @@ def get_cache_key(self: "SamlCredentialsProvider") -> str:
     def get_saml_assertion(self: "SamlCredentialsProvider"):
         pass
 
+    @staticmethod
+    def close_window_http_resp() -> bytes:
+        return str.encode(
+            "HTTP/1.1 200 OK\nContent-Type: text/html\n\n"
+            + "<html><body>Thank you for using Amazon Redshift! You can now close this window.</body></html>\n"
+        )
+
     def check_required_parameters(self: "SamlCredentialsProvider") -> None:
         if self.user_name == "" or self.user_name is None:
             raise InterfaceError("Missing required property: user_name")
