Transform checks for error.code to error.name in try-catch (#808)

Author: trivikr

.changeset/poor-poems-flash.md

@@ -0,0 +1,5 @@
+---
+"aws-sdk-js-codemod": patch
+---
+
+Transform checks for error.code to error.name in try-catch

src/transforms/v2-to-v3/__fixtures__/aws-error-name/global-import.input.js

@@ -0,0 +1,15 @@
+import AWS from "aws-sdk";
+
+const client = new AWS.S3();
+
+try {
+  await client.createBucket({
+    Bucket: "bucket"
+  }).promise();
+} catch (error) {
+  if (error.code === "BucketAlreadyExists") {
+    // Handle BucketAlreadyExists error
+  } else {
+    throw error;
+  }
+}

src/transforms/v2-to-v3/__fixtures__/aws-error-name/global-import.input.ts

@@ -0,0 +1,15 @@
+import AWS from "aws-sdk";
+
+export const func = async (client: AWS.S3) => {
+  try {
+    await client.createBucket({
+      Bucket: "bucket"
+    }).promise();
+  } catch (error) {
+    if (error.code === "BucketAlreadyExists") {
+      // Handle BucketAlreadyExists error
+    } else {
+      throw error;
+    }
+  }
+}

src/transforms/v2-to-v3/__fixtures__/aws-error-name/global-import.output.js

@@ -0,0 +1,15 @@
+import { S3 } from "@aws-sdk/client-s3";
+
+const client = new S3();
+
+try {
+  await client.createBucket({
+    Bucket: "bucket"
+  });
+} catch (error) {
+  if (error.name === "BucketAlreadyExists") {
+    // Handle BucketAlreadyExists error
+  } else {
+    throw error;
+  }
+}

src/transforms/v2-to-v3/__fixtures__/aws-error-name/global-import.output.ts

@@ -0,0 +1,15 @@
+import { S3 } from "@aws-sdk/client-s3";
+
+export const func = async (client: S3) => {
+  try {
+    await client.createBucket({
+      Bucket: "bucket"
+    });
+  } catch (error) {
+    if (error.name === "BucketAlreadyExists") {
+      // Handle BucketAlreadyExists error
+    } else {
+      throw error;
+    }
+  }
+}

src/transforms/v2-to-v3/__fixtures__/aws-error-name/service-import.input.js

@@ -0,0 +1,15 @@
+import { S3 } from "aws-sdk";
+
+const client = new S3();
+
+try {
+  await client.createBucket({
+    Bucket: "bucket"
+  }).promise();
+} catch (error) {
+  if (error.code === "BucketAlreadyExists") {
+    // Handle BucketAlreadyExists error
+  } else {
+    throw error;
+  }
+}

src/transforms/v2-to-v3/__fixtures__/aws-error-name/service-import.input.ts

@@ -0,0 +1,15 @@
+import { S3 } from "aws-sdk";
+
+export const func = async (client: S3) => {
+  try {
+    await client.createBucket({
+      Bucket: "bucket"
+    }).promise();
+  } catch (error) {
+    if (error.code === "BucketAlreadyExists") {
+      // Handle BucketAlreadyExists error
+    } else {
+      throw error;
+    }
+  }
+}

src/transforms/v2-to-v3/__fixtures__/aws-error-name/service-import.output.js

@@ -0,0 +1,15 @@
+import { S3 } from "@aws-sdk/client-s3";
+
+const client = new S3();
+
+try {
+  await client.createBucket({
+    Bucket: "bucket"
+  });
+} catch (error) {
+  if (error.name === "BucketAlreadyExists") {
+    // Handle BucketAlreadyExists error
+  } else {
+    throw error;
+  }
+}

src/transforms/v2-to-v3/__fixtures__/aws-error-name/service-import.output.ts

@@ -0,0 +1,15 @@
+import { S3 } from "@aws-sdk/client-s3";
+
+export const func = async (client: S3) => {
+  try {
+    await client.createBucket({
+      Bucket: "bucket"
+    });
+  } catch (error) {
+    if (error.name === "BucketAlreadyExists") {
+      // Handle BucketAlreadyExists error
+    } else {
+      throw error;
+    }
+  }
+}

src/transforms/v2-to-v3/apis/addEmptyObjectForUndefined.ts

@@ -9,7 +9,6 @@ export const addEmptyObjectForUndefined = (
   clientIdentifiers: ClientIdentifier[]
 ): void => {
   for (const clientId of clientIdentifiers) {
-    // Remove .promise() from client API calls.
     source
       .find(j.CallExpression, {
         callee: {