Transform DynamoDB DocumentClient wrapNumbers option (#539)

Author: trivikr

.changeset/curly-shoes-visit.md

@@ -0,0 +1,5 @@
+---
+"aws-sdk-js-codemod": patch
+---
+
+Transform DynamoDB DocumentClient wrapNumbers option

src/transforms/v2-to-v3/__fixtures__/ddb-doc-client/param-all.input.js

@@ -0,0 +1,8 @@
+import AWS from "aws-sdk";
+
+const params = { region: "us-west-2" };
+const documentClient = new AWS.DynamoDB.DocumentClient({
+  convertEmptyValues: true,
+  service: new AWS.DynamoDB(params),
+  wrapNumbers: true
+});

src/transforms/v2-to-v3/__fixtures__/ddb-doc-client/param-all.output.js

@@ -0,0 +1,13 @@
+import { DynamoDBDocument } from "@aws-sdk/lib-dynamodb";
+import { DynamoDB } from "@aws-sdk/client-dynamodb";
+
+const params = { region: "us-west-2" };
+const documentClient = DynamoDBDocument.from(new DynamoDB(params), {
+  marshallOptions: {
+    convertEmptyValues: true
+  },
+
+  unmarshallOptions: {
+    wrapNumbers: true
+  }
+});

src/transforms/v2-to-v3/__fixtures__/ddb-doc-client/param-wrap-numbers.input.js

@@ -0,0 +1,5 @@
+import AWS from "aws-sdk";
+
+const documentClient = new AWS.DynamoDB.DocumentClient({
+  wrapNumbers: true,
+});

src/transforms/v2-to-v3/__fixtures__/ddb-doc-client/param-wrap-numbers.output.js

@@ -0,0 +1,8 @@
+import { DynamoDBDocument } from "@aws-sdk/lib-dynamodb";
+import { DynamoDB } from "@aws-sdk/client-dynamodb";
+
+const documentClient = DynamoDBDocument.from(new DynamoDB(), {
+  unmarshallOptions: {
+    wrapNumbers: true
+  }
+});

src/transforms/v2-to-v3/client-instances/getDynamoDBDocClientArgs.ts

@@ -29,15 +29,20 @@ export const getDynamoDBDocClientArgs = (
           continue;
         }
 
-        if (propertyKey.name === "convertEmptyValues") {
+        const docClientOptionsHash: Record<string, string> = {
+          convertEmptyValues: "marshallOptions",
+          wrapNumbers: "unmarshallOptions",
+        };
+
+        if (Object.keys(docClientOptionsHash).includes(propertyKey.name)) {
           dynamoDBDocClientOptions.properties.push(
             j.property(
               "init",
-              j.identifier("marshallOptions"),
+              j.identifier(docClientOptionsHash[propertyKey.name]),
               j.objectExpression([
                 j.property(
                   "init",
-                  j.identifier("convertEmptyValues"),
+                  j.identifier(propertyKey.name),
                   (property as Property | ObjectProperty).value
                 ),
               ])

src/transforms/v2-to-v3/client-instances/getDynamoDBForDocClient.ts

@@ -41,7 +41,7 @@ export const getDynamoDBForDocClient = (
   const v3DocClientArgs = v2DocClientArgs[0];
   const v3DocClientNewExpressionArgs = [];
 
-  // Remove DocumentClient option convertEmptyValues.
+  // Remove DocumentClient option convertEmptyValues and wrapNumbers.
   if (v3DocClientArgs.type === "ObjectExpression") {
     v3DocClientArgs.properties = v3DocClientArgs.properties.filter((property) => {
       if (!OBJECT_PROPERTY_TYPE_LIST.includes(property.type)) {
@@ -51,7 +51,7 @@ export const getDynamoDBForDocClient = (
       if (propertyKey.type !== "Identifier") {
         return true;
       }
-      return propertyKey.name !== "convertEmptyValues";
+      return !["convertEmptyValues", "wrapNumbers"].includes(propertyKey.name);
     });
 
     if (v3DocClientArgs.properties.length > 0) {