Suppressing dedicated file descriptors for LOG, ERR, OUT and STACK.

I can not figure out why I introduced them at first :(

Author: pgrange

README.md

@@ -510,15 +510,9 @@ EOF
 This test calls *code*, which calls *ps*, which is actually implemented by *_ps*. Since *code* does not use *ax* but only *a* as parameters, this test should fail. But...
 
 ```output
-Running test_code_gives_ps_appropriate_parameters... FAILURE
- expected [ax] but was [a]
-doc:13:_ps()
-doc:2:code()
-doc:18:test_code_gives_ps_appropriate_parameters()
-SUCCESS
+Running test_code_gives_ps_appropriate_parameters... SUCCESS
 ```
 
-This test displays FAILURE but it actually succeed, see SUCCESS at the end.
 The problem here is that *ps* fail (because of the failed *assert_equals* assertion). But *ps* is piped with *grep*:
 
 ```shell
@@ -551,14 +545,10 @@ The problem here is that we use a trick to make the code under test fail but the
 failure has nothing to do with the actual *assert_equals* failure. This is really
 bad, don't do that.
 
-Even if the output really looks like what we would expect, don't do that:
+Moreover, *assert_equals* output is captured by *ps* and this just messes with the display of our test results:
 
 ```output
-Running test_code_gives_ps_appropriate_parameters... FAILURE
- expected [ax] but was [a]
-doc:7:_ps()
-doc:2:code()
-doc:12:test_code_gives_ps_appropriate_parameters()
+Running test_code_gives_ps_appropriate_parameters... 
 ```
 
 The only correct alternative is for the fake *ps* to write *FAKE_PARAMS* in a file descriptor

bash_unit

@@ -23,16 +23,6 @@ GREEN="${ESCAPE}[92m"
 YELLOW="${ESCAPE}[93m"
 BLUE="${ESCAPE}[94m"
 
-# All tests informations must be sent to the following three
-# file descriptors:
-# LOG -> all test logs, such as SUCCESS, FAILURE, stacktrace...
-# OUT -> all code under test outputs relevant in the context
-# ERR -> all code under test error outputs relevant in the context
-exec {LOG}>&1
-exec {STACK}>&1
-exec {OUT}>&1
-exec {ERR}>&1
-
 fail() {
   local message=$1
   local stdout=$2
@@ -188,61 +178,61 @@ color() {
 text_format() {
   notify_suite_starting() {
     test_file="$1"
-    echo "Running tests in $test_file" >&$LOG
+    echo "Running tests in $test_file"
   }
   notify_test_starting() {
     local test="$1"
-    echo -n "Running $test... " | color "$BLUE" >&$LOG
+    echo -n "Running $test... " | color "$BLUE"
   }
   notify_test_succeeded() {
-    color "$GREEN" "SUCCESS" >&$LOG
+    color "$GREEN" "SUCCESS"
   }
   notify_test_failed() {
     local message="$2"
-    color "$RED" "FAILURE" >&$LOG
-    [[ -z $message  ]] || printf -- "$message\n" >&$LOG
+    color "$RED" "FAILURE"
+    [[ -z $message  ]] || printf -- "$message\n"
   }
   notify_stdout() {
-    sed 's:^:out> :' | color $GREEN >&$OUT
+    sed 's:^:out> :' | color $GREEN
   }
   notify_stderr() {
-    sed 's:^:err> :' | color $RED   >&$ERR
+    sed 's:^:err> :' | color $RED
   }
   notify_stack() {
-    color "$YELLOW" >&$STACK
+    color "$YELLOW"
   }
 }
 
 tap_format() {
   notify_suite_starting() {
     test_file="$1"
-    echo "# Running tests in $test_file" >&$LOG
+    echo "# Running tests in $test_file"
   }
   notify_test_starting() {
     echo -n
   }
   notify_test_succeeded() {
     local test="$1"
-    echo -n "ok" | color "$GREEN" >&$LOG
-    echo -n ' - ' >&$LOG
-    echo "$test" | color "$BLUE" >&$LOG
+    echo -n "ok" | color "$GREEN"
+    echo -n ' - '
+    echo "$test" | color "$BLUE"
   }
   notify_test_failed() {
     local test="$1"
     local message="$2"
-    echo -n "not ok" | color "$RED" >&$LOG
-    echo -n " - " >&$LOG
-    echo "$test" >&$LOG
-    [[ -z $message  ]] || printf -- "$message\n" | sed -u -e 's/^/# /' >&$LOG
+    echo -n "not ok" | color "$RED"
+    echo -n " - "
+    echo "$test"
+    [[ -z $message  ]] || printf -- "$message\n" | sed -u -e 's/^/# /'
   }
   notify_stdout() {
-    sed 's:^:# out> :' | color $GREEN >&$OUT
+    sed 's:^:# out> :' | color $GREEN
   }
   notify_stderr() {
-    sed 's:^:# err> :' | color $RED   >&$ERR
+    sed 's:^:# err> :' | color $RED
   }
   notify_stack() {
-    sed 's:^:# :' | color "$YELLOW"   >&$STACK
+    sed 's:^:# :' | color "$YELLOW"
   }
 }
 

tests/test_bash_unit.sh

@@ -85,7 +85,7 @@ test_assert_shows_stderr_on_failure() {
   )"
 
   assert_equals "\
-err> some error message" \
+some error message" \
     "$message"
 }
 
@@ -95,8 +95,8 @@ test_assert_shows_stdout_on_failure() {
   )"
 
   assert_equals "\
-out> some ok message
-out> another ok message" \
+some ok message
+another ok message" \
     "$message"
 }
 
@@ -238,58 +238,79 @@ last_line() {
 }
 
 with_bash_unit_muted() {
-  with_bash_unit_redirected "$@"
+  with_bash_unit_notifications_muted "$@"
 }
 
 with_bash_unit_err() {
-  with_bash_unit_redirected -e '&1' "$@"
+  with_bash_unit_notifications_muted -e "$@"
 }
 
 with_bash_unit_out() {
-  with_bash_unit_redirected -o '&1' "$@"
+  with_bash_unit_notifications_muted -o "$@"
 }
 
 with_bash_unit_log() {
-  with_bash_unit_redirected -l '&1' "$@"
+  with_bash_unit_notifications_muted -l "$@"
 }
 
 with_bash_unit_stack() {
-  with_bash_unit_redirected -s '&1' "$@"
-}
-
-with_bash_unit_redirected() {
-  local log=/dev/null
-  local stack=/dev/null
-  local out=/dev/null
-  local err=/dev/null
-
-  unset OPTIND
-  while getopts "l:s:o:e:" option
-  do
-    case "$option" in
-      l)
-        log=$OPTARG
-        ;;
-      s)
-        stack=$OPTARG
-        ;;
-      o)
-        out=$OPTARG
-        ;;
-      e)
-        err=$OPTARG
-        ;;
-    esac
-  done
-  shift $((OPTIND-1))
+  with_bash_unit_notifications_muted -s "$@"
+}
 
+with_bash_unit_notifications_muted() {
   (
-    eval "exec {LOG}>$log"
-    eval "exec {STACK}>$stack"
-    eval "exec {OUT}>$out"
-    eval "exec {ERR}>$err"
+    mute
+    unset OPTIND
+    while getopts "lsoe" option
+    do
+      case "$option" in
+        l)
+          unmute_logs
+          ;;
+        s)
+          unmute_stack
+          ;;
+        o)
+          unmute_out
+          ;;
+        e)
+          unmute_err
+          ;;
+      esac
+    done
+    shift $((OPTIND-1))
+
     "$@"
   )
 }
 
+unmute_logs() {
+  notify_suite_starting() { echo "Running tests in $1" ; }
+  notify_test_starting () { echo -n "Running $1... " ; }
+  notify_test_succeeded() { echo "SUCCESS" ; }
+  notify_test_failed   () { echo "FAILURE" ; echo $2 ; }
+}
+
+unmute_stack() {
+  notify_stack() { cat ; }
+}
+
+unmute_out() {
+  notify_stdout() { cat ; }
+}
+
+unmute_err() {
+  notify_stderr() { cat ; }
+}
+
+mute() {
+  notify_suite_starting() { echo -n ; }
+  notify_test_starting () { echo -n ; }
+  notify_test_succeeded() { echo -n ; }
+  notify_test_failed   () { echo -n ; }
+  notify_stack         () { echo -n ; }
+  notify_stdout        () { echo -n ; }
+  notify_stderr        () { echo -n ; }
+}
+
 BASH_UNIT=../bash_unit