Merge pull request #370 from DannyBen/add/allowed-pair-validation

Add validation alert when `allowed` is provided without either a `default` or `required`

Author: DannyBen

examples/completions/README.md

@@ -60,6 +60,8 @@ commands:
       - curl
       - wget
 
+    default: curl
+
   examples:
   - cli download example.com
   - cli download example.com ./output -f

examples/completions/src/bashly.yml

@@ -38,6 +38,8 @@ commands:
       - curl
       - wget
 
+    default: curl
+
   examples:
   - cli download example.com
   - cli download example.com ./output -f

lib/bashly/config_validator.rb

@@ -101,6 +101,11 @@ def assert_arg(key, value)
       refute value['name'].match(/^-/), "#{key}.name must not start with '-'"
 
       refute value['required'] && value['default'], "#{key} cannot have both required and default"
+
+      if value['allowed']
+        assert (value['required'] || value['default']),
+          "#{key}.allowed does not make sense without either default or required"
+      end
     end
 
     def assert_flag(key, value)
@@ -135,6 +140,8 @@ def assert_flag(key, value)
 
       if value['allowed']
         assert value['arg'], "#{key}.allowed does not make sense without arg"
+        assert (value['required'] || value['default']),
+          "#{key}.allowed does not make sense without either default or required"
       end
 
       if value['completions']