-
-
Notifications
You must be signed in to change notification settings - Fork 640
ci: add ci config to test 7 and 8 for bcr like setup #3404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
aignas
wants to merge
10
commits into
bazel-contrib:main
Choose a base branch
from
aignas:aignas.chore.bump-for-bazel-9
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+66
−115
Draft
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
a996fce
simplify the initial port/uniification
aignas 732c425
update rules_go, gazelle and java
aignas e89a50b
fix the bazelrc
aignas 1e4f22a
update C++
aignas b39a19b
better job naming
aignas 17a8e55
attempt bazel version in the job title
aignas 4f44c17
Revert "attempt bazel version in the job title"
aignas b91a618
Only use bazel 7 and 8
aignas cd86638
revert rules_python to rules_go 41, gazelle 40
rickeylev b2be8f3
Merge branch 'main' into aignas.chore.bump-for-bazel-9
aignas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -91,7 +91,50 @@ buildifier: | |
| - //tests:version_3_13_test | ||
| - //tests:version_3_14_test | ||
| - //tests:version_default_test | ||
|
|
||
| matrix: | ||
| platform: | ||
| - ubuntu2204 | ||
| - debian11 | ||
| - macos_arm64 | ||
| - windows | ||
| bazel: [7.*, 8.*, 9.*] | ||
|
|
||
| tasks: | ||
| bcr_test: | ||
| name: BCR example - rules_python | ||
| platform: ${{ platform }} | ||
| working_directory: examples/bzlmod | ||
| bazel: ${{ bazel }} | ||
| test_flags: | ||
| # Minimum bazel supported C++ | ||
| - "--keep_going" | ||
| - '--cxxopt=-std=c++17' | ||
| - '--host_cxxopt=-std=c++17' | ||
| build_targets: | ||
| - "//..." | ||
| test_targets: | ||
| - "//..." | ||
|
|
||
| bcr_gazelle_test: | ||
| name: BCR example - rules_python_gazelle_plugin | ||
| platform: ${{ platform }} | ||
| bazel: ${{ bazel }} | ||
| working_directory: gazelle/examples/bzlmod_build_file_generation | ||
| shell_commands: | ||
| - "echo 'common --override_module=rules_python=' >> .bazelrc" | ||
| - "bazel run //:gazelle_python_manifest.update" | ||
| - "bazel run //:gazelle -- update" | ||
| batch_commands: | ||
| - "echo common --override_module=rules_python= >> .bazelrc" | ||
| - "bazel run //:gazelle_python_manifest.update" | ||
| - "bazel run //:gazelle -- update" | ||
| build_targets: | ||
| - "//..." | ||
| - ":modules_map" | ||
| test_targets: | ||
| - "//..." | ||
|
|
||
| gazelle_extension_min: | ||
| <<: *common_workspace_flags_min_bazel | ||
| <<: *minimum_supported_version | ||
|
|
@@ -262,113 +305,15 @@ tasks: | |
| working_directory: examples/build_file_generation | ||
| platform: windows | ||
|
|
||
| integration_test_bzlmod_ubuntu_min: | ||
| <<: *minimum_supported_version | ||
| <<: *reusable_build_test_all | ||
| coverage_targets: ["//:test"] | ||
| name: "examples/bzlmod: Ubuntu, minimum Bazel" | ||
| working_directory: examples/bzlmod | ||
| platform: ubuntu2204 | ||
| bazel: 7.x | ||
| integration_test_bzlmod_ubuntu: | ||
| <<: *reusable_build_test_all | ||
| <<: *coverage_targets_example_bzlmod | ||
| name: "examples/bzlmod: Ubuntu" | ||
| working_directory: examples/bzlmod | ||
| platform: ubuntu2204 | ||
| bazel: 7.x | ||
| integration_test_bzlmod_ubuntu_upcoming: | ||
| <<: *reusable_build_test_all | ||
| <<: *coverage_targets_example_bzlmod | ||
| name: "examples/bzlmod: Ubuntu, upcoming Bazel" | ||
| working_directory: examples/bzlmod | ||
| platform: ubuntu2204 | ||
| bazel: last_rc | ||
| integration_test_bzlmod_debian: | ||
| <<: *reusable_build_test_all | ||
| <<: *coverage_targets_example_bzlmod | ||
| name: "examples/bzlmod: Debian" | ||
| working_directory: examples/bzlmod | ||
| platform: debian11 | ||
| bazel: 7.x | ||
| integration_test_bzlmod_ubuntu_vendor: | ||
| <<: *reusable_build_test_all | ||
| name: "examples/bzlmod: bazel vendor" | ||
| working_directory: examples/bzlmod | ||
| platform: ubuntu2204 | ||
| shell_commands: | ||
| - "bazel vendor --vendor_dir=./vendor //..." | ||
| - "bazel build --vendor_dir=./vendor //..." | ||
| - "rm -rf ./vendor" | ||
| integration_test_bzlmod_macos: | ||
| <<: *reusable_build_test_all | ||
| <<: *coverage_targets_example_bzlmod | ||
| name: "examples/bzlmod: macOS" | ||
| working_directory: examples/bzlmod | ||
| platform: macos_arm64 | ||
| bazel: 7.x | ||
| integration_test_bzlmod_macos_upcoming: | ||
| <<: *reusable_build_test_all | ||
| <<: *coverage_targets_example_bzlmod | ||
| name: "examples/bzlmod: macOS, upcoming Bazel" | ||
| working_directory: examples/bzlmod | ||
| platform: macos_arm64 | ||
| bazel: last_rc | ||
| integration_test_bzlmod_windows: | ||
| <<: *reusable_build_test_all | ||
| # coverage is not supported on Windows | ||
| name: "examples/bzlmod: Windows" | ||
| working_directory: examples/bzlmod | ||
| platform: windows | ||
| bazel: 7.x | ||
| integration_test_bzlmod_windows_upcoming: | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Well, now I'm a bit confused. Yet in this PR's refactored CI run, it's also giving the error BCR is giving. The only difference seems to be the vendor step? |
||
| <<: *reusable_build_test_all | ||
| # coverage is not supported on Windows | ||
| name: "examples/bzlmod: Windows, upcoming Bazel" | ||
| working_directory: examples/bzlmod | ||
| platform: windows | ||
| bazel: last_rc | ||
|
|
||
| integration_test_bzlmod_generate_build_file_generation_ubuntu_min: | ||
| <<: *minimum_supported_version | ||
| <<: *reusable_build_test_all | ||
| <<: *coverage_targets_example_bzlmod_build_file_generation | ||
| name: "gazelle/examples/bzlmod_build_file_generation: Ubuntu, minimum Bazel" | ||
| working_directory: gazelle/examples/bzlmod_build_file_generation | ||
| platform: ubuntu2204 | ||
| bazel: 7.x | ||
| integration_test_bzlmod_generation_build_files_ubuntu: | ||
| <<: *reusable_build_test_all | ||
| <<: *coverage_targets_example_bzlmod_build_file_generation | ||
| name: "gazelle/examples/bzlmod_build_file_generation: Ubuntu" | ||
| working_directory: gazelle/examples/bzlmod_build_file_generation | ||
| platform: ubuntu2204 | ||
| integration_test_bzlmod_generation_build_files_ubuntu_run: | ||
| <<: *reusable_build_test_all | ||
| name: "gazelle/examples/bzlmod_build_file_generation: Ubuntu, Gazelle and pip" | ||
| working_directory: gazelle/examples/bzlmod_build_file_generation | ||
| platform: ubuntu2204 | ||
| shell_commands: | ||
| - "bazel run //:gazelle_python_manifest.update" | ||
| - "bazel run //:gazelle -- update" | ||
| integration_test_bzlmod_build_file_generation_debian: | ||
| <<: *reusable_build_test_all | ||
| <<: *coverage_targets_example_bzlmod_build_file_generation | ||
| name: "gazelle/examples/bzlmod_build_file_generation: Debian" | ||
| working_directory: gazelle/examples/bzlmod_build_file_generation | ||
| platform: debian11 | ||
| integration_test_bzlmod_build_file_generation_macos: | ||
| <<: *reusable_build_test_all | ||
| <<: *coverage_targets_example_bzlmod_build_file_generation | ||
| name: "gazelle/examples/bzlmod_build_file_generation: MacOS" | ||
| working_directory: gazelle/examples/bzlmod_build_file_generation | ||
| platform: macos_arm64 | ||
| integration_test_bzlmod_build_file_generation_windows: | ||
| <<: *reusable_build_test_all | ||
| # coverage is not supported on Windows | ||
| name: "gazelle/examples/bzlmod_build_file_generation: Windows" | ||
| working_directory: gazelle/examples/bzlmod_build_file_generation | ||
| platform: windows | ||
| - "bazel vendor --vendor_dir=./vendor //..." | ||
| - "bazel build --vendor_dir=./vendor //..." | ||
| - "rm -rf ./vendor" | ||
|
|
||
| integration_test_multi_python_versions_ubuntu_workspace: | ||
| <<: *reusable_build_test_all | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.