Renamed HttpStatisticsLogger with MemoryStatisticsLogger (because it stores it in-memory)

Author: rennokki

config/websockets.php

@@ -212,7 +212,7 @@
         |
         */
 
-        'logger' => \BeyondCode\LaravelWebSockets\Statistics\Logger\HttpStatisticsLogger::class,
+        'logger' => \BeyondCode\LaravelWebSockets\Statistics\Logger\MemoryStatisticsLogger::class,
         // 'logger' => \BeyondCode\LaravelWebSockets\Statistics\Logger\NullStatisticsLogger::class,
 
         /*

docs/debugging/dashboard.md

@@ -88,7 +88,7 @@ However, to disable it entirely and void any incoming statistic, you can uncomme
 |
 */
 
-// 'logger' => \BeyondCode\LaravelWebSockets\Statistics\Logger\HttpStatisticsLogger::class,
+// 'logger' => \BeyondCode\LaravelWebSockets\Statistics\Logger\MemoryStatisticsLogger::class,
 'logger' => \BeyondCode\LaravelWebSockets\Statistics\Logger\NullStatisticsLogger::class, // use the `NullStatisticsLogger` instead
 ```
 

src/Console/StartWebSocketServer.php

@@ -33,6 +33,7 @@ class StartWebSocketServer extends Command
     protected $signature = 'websockets:serve
         {--host=0.0.0.0}
         {--port=6001}
+        {--statistics-interval= : Overwrite the statistics interval set in the config.}
         {--debug : Forces the loggers to be enabled and thereby overriding the APP_DEBUG setting.}
         {--test : Prepare the server, but do not start it.}
     ';
@@ -110,15 +111,17 @@ protected function configureStatisticsLogger()
         $browser = new Browser($this->loop, $connector);
 
         $this->laravel->singleton(StatisticsLoggerInterface::class, function () use ($browser) {
-            $class = config('websockets.statistics.logger', \BeyondCode\LaravelWebSockets\Statistics\Logger\HttpStatisticsLogger::class);
+            $class = config('websockets.statistics.logger', \BeyondCode\LaravelWebSockets\Statistics\Logger\MemoryStatisticsLogger::class);
 
             return new $class(
                 $this->laravel->make(ChannelManager::class),
                 $browser
             );
         });
 
-        $this->loop->addPeriodicTimer(config('websockets.statistics.interval_in_seconds'), function () {
+        $this->loop->addPeriodicTimer($this->option('statistics-interval') ?: config('websockets.statistics.interval_in_seconds'), function () {
+            $this->line('Saving statistics...');
+
             StatisticsLogger::save();
         });
 

src/Facades/StatisticsLogger.php

@@ -6,8 +6,8 @@
 use Illuminate\Support\Facades\Facade;
 
 /**
- * @see   \BeyondCode\LaravelWebSockets\Statistics\Logger\HttpStatisticsLogger
- * @mixin \BeyondCode\LaravelWebSockets\Statistics\Logger\HttpStatisticsLogger
+ * @see   \BeyondCode\LaravelWebSockets\Statistics\Logger\MemoryStatisticsLogger
+ * @mixin \BeyondCode\LaravelWebSockets\Statistics\Logger\MemoryStatisticsLogger
  */
 class StatisticsLogger extends Facade
 {

src/Statistics/Logger/HttpStatisticsLogger.php renamed to src/Statistics/Logger/MemoryStatisticsLogger.php

@@ -10,7 +10,7 @@
 use function GuzzleHttp\Psr7\stream_for;
 use Ratchet\ConnectionInterface;
 
-class HttpStatisticsLogger implements StatisticsLogger
+class MemoryStatisticsLogger implements StatisticsLogger
 {
     /**
      * The list of stored statistics.

tests/Statistics/Logger/FakeStatisticsLogger.php

@@ -2,10 +2,13 @@
 
 namespace BeyondCode\LaravelWebSockets\Tests\Statistics\Logger;
 
-use BeyondCode\LaravelWebSockets\Statistics\Logger\HttpStatisticsLogger;
+use BeyondCode\LaravelWebSockets\Statistics\Logger\MemoryStatisticsLogger;
 
-class FakeStatisticsLogger extends HttpStatisticsLogger
+class FakeStatisticsLogger extends MemoryStatisticsLogger
 {
+    /**
+     * {@inheritdoc}
+     */
     public function save()
     {
         foreach ($this->statistics as $appId => $statistic) {
@@ -14,6 +17,12 @@ public function save()
         }
     }
 
+    /**
+     * Get app by id.
+     *
+     * @param  mixed  $appId
+     * @return array
+     */
     public function getForAppId($appId): array
     {
         $statistic = $this->findOrMakeStatisticForAppId($appId);