fix: 只设置privateCertString或PrivateCertContent导致certSerialNo没有生成 #3758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
此 PR 修复了一个 Bug：当只设置 privateCertString 或 PrivateCertContent 时，certSerialNo 没有被正确生成。
主要变更：
- 修正了
WxPayConfig.java中证书序列号提取的条件判断逻辑 - 统一了公钥路径检查的判断方式，使用
StringUtils.isNotBlank()替代 null 检查 - 添加了测试用例以验证修复
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| WxPayConfig.java | 修复了证书序列号提取的条件判断逻辑，并统一了公钥路径的空值检查方式 |
| BaseWxPayServiceImplTest.java | 添加了新的测试用例，用于验证从 PrivateCertContent 或 PrivateCertString 提取证书序列号的功能 |
...ava-pay/src/test/java/com/github/binarywang/wxpay/service/impl/BaseWxPayServiceImplTest.java
Outdated
Show resolved
Hide resolved
…ice/impl/BaseWxPayServiceImplTest.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #3757