Agent streaming #1302
Closed
Agent streaming #1302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
Greptile OverviewGreptile SummaryAdded streaming support to V3 non-CUA agents by implementing a new Major Changes
Issues Found
Confidence Score: 4/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant V3
participant V3AgentHandler
participant LLMClient
participant AI_SDK
User->>V3: agent(options).stream(instruction)
V3->>V3AgentHandler: new V3AgentHandler()
V3->>V3AgentHandler: stream(instruction)
V3AgentHandler->>V3AgentHandler: prepareAgent()
Note over V3AgentHandler: Build system prompt,<br/>wrap model, create tools
V3AgentHandler->>V3AgentHandler: Create AgentState
Note over V3AgentHandler: collectedReasoning,<br/>actions, completed, etc.
V3AgentHandler->>V3AgentHandler: Create result promise<br/>(resolveResult, rejectResult)
V3AgentHandler->>LLMClient: streamText(config + onStepFinish + onFinish)
LLMClient->>AI_SDK: streamText()
AI_SDK-->>User: Return StreamTextResult<br/>(textStream, fullStream)
loop For each step
AI_SDK->>V3AgentHandler: onStepFinish(event)
V3AgentHandler->>V3AgentHandler: createStepHandler(state)
Note over V3AgentHandler: Process tool calls,<br/>update state (reasoning, actions),<br/>check for "close" tool
end
AI_SDK->>V3AgentHandler: onFinish(event)
V3AgentHandler->>V3AgentHandler: consolidateMetricsAndResult()
Note over V3AgentHandler: Build final AgentResult,<br/>update metrics
V3AgentHandler->>V3AgentHandler: resolveResult(AgentResult)
User->>User: await result.result
User-->>User: Receive final AgentResult
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| }); | ||
|
|
||
| const result = await agent.stream({ | ||
| instruction: "go to amazon, and seach for shampoo, stop after searching", |
Contributor
There was a problem hiding this comment.
syntax: typo: "seach" should be "search"
Suggested change
| instruction: "go to amazon, and seach for shampoo, stop after searching", | |
| instruction: "go to amazon, and search for shampoo, stop after searching", |
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/core/examples/agent_stream_example.ts
Line: 29:29
Comment:
**syntax:** typo: "seach" should be "search"
```suggestion
instruction: "go to amazon, and search for shampoo, stop after searching",
```
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
+218
to
+223
| let resolveResult: (value: AgentResult | PromiseLike<AgentResult>) => void; | ||
| let rejectResult: (reason?: string) => void; | ||
| const resultPromise = new Promise<AgentResult>((resolve, reject) => { | ||
| resolveResult = resolve; | ||
| rejectResult = reject; | ||
| }); |
Contributor
There was a problem hiding this comment.
syntax: uninitialized variables resolveResult and rejectResult are used before assignment
The variables are declared but not initialized, then passed to the Promise constructor. TypeScript should complain about this with strict mode enabled.
Suggested change
| let resolveResult: (value: AgentResult | PromiseLike<AgentResult>) => void; | |
| let rejectResult: (reason?: string) => void; | |
| const resultPromise = new Promise<AgentResult>((resolve, reject) => { | |
| resolveResult = resolve; | |
| rejectResult = reject; | |
| }); | |
| const resultPromise = new Promise<AgentResult>((resolve, reject) => { | |
| resolveResult = resolve; | |
| rejectResult = reject; | |
| }); |
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/core/lib/v3/handlers/v3AgentHandler.ts
Line: 218:223
Comment:
**syntax:** uninitialized variables `resolveResult` and `rejectResult` are used before assignment
The variables are declared but not initialized, then passed to the Promise constructor. TypeScript should complain about this with strict mode enabled.
```suggestion
const resultPromise = new Promise<AgentResult>((resolve, reject) => {
resolveResult = resolve;
rejectResult = reject;
});
```
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
+242
to
+244
| } catch (error) { | ||
| rejectResult(error); | ||
| } |
Contributor
There was a problem hiding this comment.
syntax: rejectResult is called with error parameter but declared to take reason?: string
The type of error in the catch block is unknown, but rejectResult expects a string. This could cause type issues.
Suggested change
| } catch (error) { | |
| rejectResult(error); | |
| } | |
| } catch (error) { | |
| rejectResult(String(error)); | |
| } |
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/core/lib/v3/handlers/v3AgentHandler.ts
Line: 242:244
Comment:
**syntax:** `rejectResult` is called with `error` parameter but declared to take `reason?: string`
The type of `error` in the catch block is `unknown`, but `rejectResult` expects a string. This could cause type issues.
```suggestion
} catch (error) {
rejectResult(String(error));
}
```
How can I resolve this? If you propose a fix, please make it concise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why
We wanted to add streaming support to the non-CUA agent in V3
what changed
Added
streammethod toV3AgentHandler:streamTextinstead ofgenerateTextAgentStreamResult, which extendsStreamTextResultwith an addedresult: Promise<AgentResult>propertyonFinishcallback to resolve the result promise with metrics and final stateConsolidated duplicate logic:
prepareAgent()helper to build context (system prompt, tools, wrapped model) for bothexecuteandstreamcreateStepHandler()to generate theonStepFinishcallback used by both methodsconsolidateMetricsAndResult()to handle metrics updates andAgentResultconstructionhandleStop()helper to check for "close" tool calls before falling back to step count limitMoved types to public agent types:
AgentContextandAgentStateinterfaces frompackages/core/lib/v3/types/public/agent.tsAgentStreamResulttype that combinesStreamTextResult<ToolSet, never>withresult: Promise<AgentResult>Updated
V3.agent()return type:streammethod alongsideexecutefor non-CUA agentsexecute(no streaming support)notes : context handling will likely be moved to prepareStep callback in the very near future, currently we have to maintain a state of the messages which is not ideal. prepareStep should eliminate the need for this