Skip to content

Commit 4d9528a

Browse files
committed
switch to wasm32-wasip1 target when using nightly rustc
The old name (`wasm32-wasip1`) is no longer recognized. Signed-off-by: Joel Dice <joel.dice@fermyon.com>
1 parent c54e926 commit 4d9528a

File tree

4 files changed

+11
-10
lines changed

4 files changed

+11
-10
lines changed

.github/workflows/release.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,12 +36,12 @@ jobs:
3636
- name: Install latest Rust nightly toolchain
3737
uses: dtolnay/rust-toolchain@nightly
3838
with:
39-
targets: wasm32-wasi wasm32-unknown-unknown
39+
targets: wasm32-wasip1 wasm32-unknown-unknown
4040

4141
- name: Install latest Rust stable toolchain
4242
uses: dtolnay/rust-toolchain@stable
4343
with:
44-
targets: wasm32-wasi wasm32-unknown-unknown
44+
targets: wasm32-wasip1 wasm32-unknown-unknown
4545
components: clippy, rustfmt
4646

4747
- name: Install Rust std source
@@ -213,7 +213,7 @@ jobs:
213213
before-script-linux: |
214214
rustup install nightly
215215
rustup component add rust-src --toolchain nightly
216-
rustup target add wasm32-wasi wasm32-unknown-unknown
216+
rustup target add wasm32-wasip1 wasm32-unknown-unknown
217217
218218
- name: Set up cross-compiled linux aarch64 build
219219
if: matrix.config.target == 'aarch64-unknown-linux-gnu'

.github/workflows/test.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,12 +33,12 @@ jobs:
3333
- name: Install latest Rust nightly toolchain
3434
uses: dtolnay/rust-toolchain@nightly
3535
with:
36-
targets: wasm32-wasi wasm32-unknown-unknown
36+
targets: wasm32-wasip1 wasm32-unknown-unknown
3737

3838
- name: Install latest Rust stable toolchain
3939
uses: dtolnay/rust-toolchain@stable
4040
with:
41-
targets: wasm32-wasi wasm32-unknown-unknown
41+
targets: wasm32-wasip1 wasm32-unknown-unknown
4242
components: clippy, rustfmt
4343

4444
- name: Install Rust std source

CONTRIBUTING.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,16 +21,17 @@ switch.
2121
### Prerequisites
2222

2323
- Tools needed to build [CPython](https://github.com/python/cpython) (Make, Clang, etc.)
24-
- [Rust](https://rustup.rs/) stable 1.71 or later *and* nightly 2023-07-27 or later, including the `wasm32-wasi` and `wasm32-unknown-unknown` targets
25-
- Note that we currently use the `-Z build-std` Cargo option to build the `componentize-py` runtime with position-independent code (which is not the default for `wasm32-wasi`) and this requires using a recent nightly build of Rust.
24+
- [Rust](https://rustup.rs/) stable 1.71 or later *and* nightly 2023-07-27 or later, including the `wasm32-wasip1` and `wasm32-unknown-unknown` targets
25+
- Note that we currently use the `-Z build-std` Cargo option to build the `componentize-py` runtime with position-independent code (which is not the default for `wasm32-wasip1`) and this requires using a recent nightly build of Rust.
2626

2727
For Rust, something like this should work once you have `rustup`:
2828

2929
```shell
3030
rustup update
3131
rustup install nightly
3232
rustup component add rust-src --toolchain nightly
33-
rustup target add wasm32-wasi wasm32-unknown-unknown
33+
rustup target add wasm32-wasip1 wasm32-unknown-unknown
34+
rustup target add --toolchain nightly wasm32-wasip1 wasm32-unknown-unknown
3435
```
3536

3637
### Building and Running

build.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ fn package_all_the_things(out_dir: &Path) -> Result<()> {
112112
.arg("-Z")
113113
.arg("build-std=panic_abort,std")
114114
.arg("--release")
115-
.arg("--target=wasm32-wasi");
115+
.arg("--target=wasm32-wasip1");
116116

117117
for (key, _) in env::vars_os() {
118118
if key
@@ -132,7 +132,7 @@ fn package_all_the_things(out_dir: &Path) -> Result<()> {
132132
assert!(status.success());
133133
println!("cargo:rerun-if-changed=runtime");
134134

135-
let path = out_dir.join("wasm32-wasi/release/libcomponentize_py_runtime.a");
135+
let path = out_dir.join("wasm32-wasip1/release/libcomponentize_py_runtime.a");
136136

137137
if path.exists() {
138138
let clang = wasi_sdk.join(format!("bin/{CLANG_EXECUTABLE}"));

0 commit comments

Comments
 (0)