Add wf type tag in decider metrics scope (#499)

Author: meiliang86

src/main/java/com/uber/cadence/internal/replay/ReplayDecider.java

@@ -29,9 +29,11 @@
 import com.uber.cadence.WorkflowExecutionSignaledEventAttributes;
 import com.uber.cadence.WorkflowExecutionStartedEventAttributes;
 import com.uber.cadence.WorkflowQuery;
+import com.uber.cadence.WorkflowType;
 import com.uber.cadence.common.RetryOptions;
 import com.uber.cadence.internal.common.OptionsUtils;
 import com.uber.cadence.internal.common.Retryer;
+import com.uber.cadence.internal.metrics.MetricsTag;
 import com.uber.cadence.internal.metrics.MetricsType;
 import com.uber.cadence.internal.replay.HistoryHelper.DecisionEvents;
 import com.uber.cadence.internal.replay.HistoryHelper.DecisionEventsIterator;
@@ -43,6 +45,7 @@
 import com.uber.cadence.workflow.Functions;
 import com.uber.m3.tally.Scope;
 import com.uber.m3.tally.Stopwatch;
+import com.uber.m3.util.ImmutableMap;
 import java.time.Duration;
 import java.util.ArrayList;
 import java.util.Iterator;
@@ -83,14 +86,18 @@ class ReplayDecider implements Decider {
   ReplayDecider(
       IWorkflowService service,
       String domain,
+      WorkflowType workflowType,
       ReplayWorkflow workflow,
       DecisionsHelper decisionsHelper,
       SingleWorkerOptions options,
       BiFunction<LocalActivityWorker.Task, Duration, Boolean> laTaskPoller) {
     this.service = service;
     this.workflow = workflow;
     this.decisionsHelper = decisionsHelper;
-    this.metricsScope = options.getMetricsScope();
+    this.metricsScope =
+        options
+            .getMetricsScope()
+            .tagged(ImmutableMap.of(MetricsTag.WORKFLOW_TYPE, workflowType.getName()));
     PollForDecisionTaskResponse decisionTask = decisionsHelper.getTask();
 
     startedEvent =

src/main/java/com/uber/cadence/internal/replay/ReplayDecisionTaskHandler.java

@@ -278,6 +278,7 @@ private Decider createDecider(PollForDecisionTaskResponse decisionTask) throws E
     }
     DecisionsHelper decisionsHelper = new DecisionsHelper(decisionTask);
     ReplayWorkflow workflow = workflowFactory.getWorkflow(workflowType);
-    return new ReplayDecider(service, domain, workflow, decisionsHelper, options, laTaskPoller);
+    return new ReplayDecider(
+        service, domain, workflowType, workflow, decisionsHelper, options, laTaskPoller);
   }
 }

src/test/java/com/uber/cadence/internal/replay/ReplayDeciderCacheTests.java

@@ -27,6 +27,7 @@
 import com.uber.cadence.PollForDecisionTaskResponse;
 import com.uber.cadence.WorkflowExecution;
 import com.uber.cadence.WorkflowQuery;
+import com.uber.cadence.WorkflowType;
 import com.uber.cadence.internal.metrics.MetricsTag;
 import com.uber.cadence.internal.metrics.MetricsType;
 import com.uber.cadence.internal.metrics.NoopScope;
@@ -256,6 +257,7 @@ private ReplayDecider createFakeDecider(PollForDecisionTaskResponse response) {
     return new ReplayDecider(
         new TestWorkflowService(),
         "domain",
+        new WorkflowType().setName("workflow"),
         new ReplayWorkflow() {
           @Override
           public void start(HistoryEvent event, DecisionContext context) {}