fix(temp): Ignore strategy and strategyConfig fields in activeClusterSelectionPolicy (#1086)

* Temporarily remove legacy activeClusterSelectionPolicy fields to allow cadence-web to parse histories of workflows using the new active-active design

Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>

Author: adhityamamallan

package.json

@@ -2,7 +2,7 @@
   "name": "cadence-web",
   "private": true,
   "config": {
-    "cadence_idl_version": "7b9d8a31de8c2af607176c2494b1ebbe5250b312"
+    "cadence_idl_version": "ac43ecefe36469b88f4efd41e2a067fdcf7a8506"
   },
   "scripts": {
     "dev": "next dev -p ${CADENCE_WEB_PORT:-8088} -H ${CADENCE_WEB_HOSTNAME:-0.0.0.0} | pino-pretty --messageKey message",

src/utils/data-formatters/schema/history-event-schema.ts

@@ -1,5 +1,6 @@
 import { z } from 'zod';
 
+import { type ActiveClusterSelectionPolicy } from '@/__generated__/proto-ts/uber/cadence/api/v1/ActiveClusterSelectionPolicy';
 import { ActiveClusterSelectionStrategy } from '@/__generated__/proto-ts/uber/cadence/api/v1/ActiveClusterSelectionStrategy';
 import { CancelExternalWorkflowExecutionFailedCause } from '@/__generated__/proto-ts/uber/cadence/api/v1/CancelExternalWorkflowExecutionFailedCause';
 import { ChildWorkflowExecutionFailedCause } from '@/__generated__/proto-ts/uber/cadence/api/v1/ChildWorkflowExecutionFailedCause';
@@ -146,39 +147,46 @@ const clusterAttributeSchema = z.object({
   name: z.string(),
 });
 
-// TODO @adhitya.mamallan - this needs to be removed as part of active-active's redesign
+// TODO @adhitya.mamallan - this needs to be removed as part of active-active's redesign, once the IDL has removed them
 const activeClusterSelectionStrategySchema = z.enum([
   ActiveClusterSelectionStrategy.ACTIVE_CLUSTER_SELECTION_STRATEGY_INVALID,
   ActiveClusterSelectionStrategy.ACTIVE_CLUSTER_SELECTION_STRATEGY_REGION_STICKY,
   ActiveClusterSelectionStrategy.ACTIVE_CLUSTER_SELECTION_STRATEGY_EXTERNAL_ENTITY,
 ]);
 
-// TODO @adhitya.mamallan - this needs to be modified as part of active-active's redesign,
-// so that we only check for clusterAttributes
-const activeClusterSelectionPolicySchema = z.discriminatedUnion(
-  'strategyConfig',
-  [
-    z.object({
-      strategy: activeClusterSelectionStrategySchema,
-      strategyConfig: z.literal('activeClusterStickyRegionConfig'),
-      activeClusterStickyRegionConfig: z.object({
-        stickyRegion: z.string(),
-      }),
-      activeClusterExternalEntityConfig: z.nullable(z.undefined()),
-      clusterAttribute: clusterAttributeSchema.nullable(),
-    }),
-    z.object({
-      strategy: activeClusterSelectionStrategySchema,
-      strategyConfig: z.literal('activeClusterExternalEntityConfig'),
-      activeClusterStickyRegionConfig: z.nullable(z.undefined()),
-      activeClusterExternalEntityConfig: z.object({
-        externalEntityType: z.string(),
-        externalEntityKey: z.string(),
-      }),
-      clusterAttribute: clusterAttributeSchema.nullable(),
-    }),
-  ]
-);
+// The IDL still contains the strategy and strategyConfig fields, but they are absent
+// in the new active-active design. The preprocess step corrects this and allows us to
+// parse activeClusterSelectionPolicy even if the backend does not pass the deprecated fields.
+//
+// TODO @adhitya.mamallan - update this once the IDL has been updated
+const activeClusterSelectionPolicySchema = z.preprocess(
+  (data) => {
+    if (typeof data === 'object' && data !== null) {
+      const dataWithDefaults = {
+        ...data,
+        strategy:
+          'strategy' in data && data.strategy
+            ? data.strategy
+            : 'ACTIVE_CLUSTER_SELECTION_STRATEGY_INVALID',
+        strategyConfig:
+          'strategyConfig' in data && data.strategyConfig
+            ? data.strategyConfig
+            : 'activeClusterStickyRegionConfig',
+      };
+      return dataWithDefaults;
+    }
+    return data;
+  },
+  z.object({
+    clusterAttribute: clusterAttributeSchema,
+    // TODO: remove the below fields once the IDL has removed them
+    strategy: activeClusterSelectionStrategySchema,
+    strategyConfig: z.enum([
+      'activeClusterStickyRegionConfig',
+      'activeClusterExternalEntityConfig',
+    ]),
+  })
+) as z.ZodType<ActiveClusterSelectionPolicy>;
 
 const failureSchema = z.object({
   reason: z.string(),