Commit 45a4db3
authored
refactor: drop cosmiconfig (#802)
### Summary
[cosmiconfig](https://github.com/cosmiconfig/cosmiconfig) is no longer
maintained. Apart from that, we can't support ESM configuration properly
because `cosmiconfig` only supports loading it asynchronously - but we
need to be able to load it synchronously in babel config.
I also took a look at
[lilconfig](https://github.com/antonk52/lilconfig), but it also has the
same limitation.
Node 20.19.0 onwards supports synchronous `require` of ESM, so this
limitation is not a technical limitation. So I decided to implement
config loading myself since we don't need any advanced features of these
config loaders such as traversing up until they find the config.
### Test plan
Tested in a sample project with both `bob build` and in the example app
with metro.1 parent bf5c337 commit 45a4db3
File tree
6 files changed
+84
-65
lines changed- packages/react-native-builder-bob
- src
- utils
6 files changed
+84
-65
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | | - | |
6 | | - | |
| 4 | + | |
7 | 5 | | |
8 | 6 | | |
9 | 7 | | |
| |||
17 | 15 | | |
18 | 16 | | |
19 | 17 | | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
| 18 | + | |
24 | 19 | | |
25 | | - | |
26 | | - | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
27 | 25 | | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
42 | 30 | | |
43 | 31 | | |
44 | 32 | | |
| |||
60 | 48 | | |
61 | 49 | | |
62 | 50 | | |
63 | | - | |
| 51 | + | |
64 | 52 | | |
65 | 53 | | |
66 | 54 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
| 32 | + | |
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
| |||
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
56 | | - | |
57 | 56 | | |
58 | 57 | | |
59 | 58 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
34 | | - | |
| 34 | + | |
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
40 | | - | |
| 40 | + | |
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
| |||
Lines changed: 68 additions & 18 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
3 | | - | |
4 | | - | |
5 | | - | |
6 | | - | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
19 | 69 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5562 | 5562 | | |
5563 | 5563 | | |
5564 | 5564 | | |
5565 | | - | |
5566 | | - | |
5567 | | - | |
5568 | | - | |
5569 | | - | |
5570 | | - | |
5571 | | - | |
5572 | | - | |
5573 | | - | |
5574 | | - | |
5575 | | - | |
5576 | | - | |
5577 | | - | |
5578 | | - | |
5579 | | - | |
5580 | | - | |
5581 | | - | |
5582 | 5565 | | |
5583 | 5566 | | |
5584 | 5567 | | |
| |||
6491 | 6474 | | |
6492 | 6475 | | |
6493 | 6476 | | |
6494 | | - | |
| 6477 | + | |
6495 | 6478 | | |
6496 | 6479 | | |
6497 | 6480 | | |
| |||
12743 | 12726 | | |
12744 | 12727 | | |
12745 | 12728 | | |
12746 | | - | |
12747 | 12729 | | |
12748 | 12730 | | |
12749 | 12731 | | |
| |||
0 commit comments