Commit c7dfe9e
fix: add abiFilters to the native template (#546)
<!-- Please provide enough information so that others can review your
pull request. -->
<!-- Keep pull requests small and focused on a single change. -->
### Summary
In the native template `abiFilters` is missing from
`externalNativeBuild` block. This means that the library would be built
for every available ABI when building the application, even if the
application itself is being built for a specific one. This is not that
problematic (besides taking more time) when using React Native aar, but
when building RN from source the core `.so` files will be built for that
specific ABI. In case the library depends on a `.so` file, it would fail
at the linking stage due to missing `.so` for the remaining ABIs.
### Test plan
See
- Expensify/App#40102
- Expensify/react-native-live-markdown#284
- https://github.com/margelo/react-native-quick-sqlite/pull/41
---------
Co-authored-by: Satyajit Sahoo <satyajit.happy@gmail.com>1 parent 148fda0 commit c7dfe9e
File tree
1 file changed
+6
-0
lines changed- packages/create-react-native-library/templates/native-common/android
1 file changed
+6
-0
lines changedLines changed: 6 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
21 | 26 | | |
22 | 27 | | |
23 | 28 | | |
| |||
75 | 80 | | |
76 | 81 | | |
77 | 82 | | |
| 83 | + | |
78 | 84 | | |
79 | 85 | | |
80 | 86 | | |
| |||
0 commit comments