fix: don't throw for missing dep if it's already in root

Author: satya164

packages/create-react-native-library/src/exampleApp/dependencies.ts

@@ -1,9 +1,14 @@
-import assert from 'node:assert';
 import path from 'path';
 import fs from 'fs-extra';
 import type { TemplateConfiguration } from '../template';
+import sortObjectKeys from '../utils/sortObjectKeys';
 
-export async function getDependencyVersionsFromExampleApp(
+type PackageJson = {
+  devDependencies?: Record<string, string>;
+};
+
+export async function alignDependencyVersionsWithExampleApp(
+  pkg: PackageJson,
   folder: string,
   config: TemplateConfiguration
 ) {
@@ -31,17 +36,18 @@ export async function getDependencyVersionsFromExampleApp(
         examplePackageJson.dependencies?.[name] ??
         examplePackageJson.devDependencies?.[name];
 
-      assert(
-        version != null,
-        `Couldn't find the package "${name}" in the example app.`
-      );
-
-      devDependencies[name] = version;
+      if (version != null) {
+        devDependencies[name] = version;
+      } else if (pkg.devDependencies?.[name] == null) {
+        throw new Error(
+          `Couldn't find the package "${name}" in the example app.`
+        );
+      }
     }
   });
 
-  return {
-    dependencies: {},
-    devDependencies,
-  };
+  pkg['devDependencies'] = sortObjectKeys({
+    ...pkg['devDependencies'],
+    ...devDependencies,
+  });
 }

packages/create-react-native-library/src/index.ts

@@ -4,7 +4,7 @@ import ora from 'ora';
 import path from 'path';
 import yargs from 'yargs';
 import { addCodegenBuildScript } from './exampleApp/addCodegenBuildScript';
-import { getDependencyVersionsFromExampleApp } from './exampleApp/dependencies';
+import { alignDependencyVersionsWithExampleApp } from './exampleApp/dependencies';
 import generateExampleApp from './exampleApp/generateExampleApp';
 import { printErrorHelp, printNextSteps, printUsedRNVersion } from './inform';
 import {
@@ -19,7 +19,6 @@ import { assertNpxExists, assertUserInput } from './utils/assert';
 import { createInitialGitCommit } from './utils/initialCommit';
 import { prompt } from './utils/prompt';
 import { resolveNpmPackageVersion } from './utils/resolveNpmPackageVersion';
-import sortObjectKeys from './utils/sortObjectKeys';
 
 const FALLBACK_BOB_VERSION = '0.38.3';
 const FALLBACK_NITRO_MODULES_VERSION = '0.22.1';
@@ -117,18 +116,11 @@ async function create(_argv: yargs.Arguments<Args>) {
   const rootPackageJson = await fs.readJson(path.join(folder, 'package.json'));
 
   if (config.example !== 'none') {
-    const { dependencies, devDependencies } =
-      await getDependencyVersionsFromExampleApp(folder, config);
-
-    rootPackageJson.dependencies = sortObjectKeys({
-      ...rootPackageJson.dependencies,
-      ...dependencies,
-    });
-
-    rootPackageJson.devDependencies = sortObjectKeys({
-      ...rootPackageJson.devDependencies,
-      ...devDependencies,
-    });
+    await alignDependencyVersionsWithExampleApp(
+      rootPackageJson,
+      folder,
+      config
+    );
   }
 
   if (

packages/create-react-native-library/templates/common/$package.json

@@ -85,7 +85,7 @@
     "@react-native/eslint-config": "^0.73.1",
     "@release-it/conventional-changelog": "^9.0.2",
     "@types/jest": "^29.5.5",
-    "@types/react": "^18.2.44",
+    "@types/react": "^19.0.12",
     "commitlint": "^19.6.1",
     "del-cli": "^5.1.0",
     "eslint": "^8.51.0",
@@ -96,8 +96,8 @@
     "nitro-codegen": "^<%- versions.nitroCodegen %>",
 <% } -%>
     "prettier": "^3.0.3",
-    "react": "17.0.2",
-    "react-native": "0.73.0",
+    "react": "19.0.0",
+    "react-native": "0.78.1",
     "react-native-builder-bob": "^<%- versions.bob %>",
 <% if (project.moduleConfig === 'nitro-modules') { -%>
     "react-native-nitro-modules": "^<%- versions.nitroModules %>",