refactor: fix typecheck and lint

Author: mdjastrzebski

src/__tests__/render-debug.test.tsx

@@ -4,7 +4,6 @@ import * as React from 'react';
 import { Pressable, Text, TextInput, View } from 'react-native';
 import stripAnsi from 'strip-ansi';
 import { configure, fireEvent, render, screen } from '..';
-import { getConfig } from '../config';
 
 const PLACEHOLDER_FRESHNESS = 'Add custom freshness';
 const PLACEHOLDER_CHEF = 'Who inspected freshness?';

src/config.ts

@@ -1,5 +1,4 @@
 import type { DebugOptions } from './helpers/debug-deep';
-import type { Renderer } from './render';
 
 /**
  * Global configuration options for React Native Testing Library.
@@ -14,9 +13,6 @@ export type Config = {
 
   /** Default options for `debug` helper. */
   defaultDebugOptions?: Partial<DebugOptions>;
-
-  /** Renderer to use for rendering components. */
-  renderer?: Renderer;
 };
 
 export type ConfigAliasOptions = {

src/fire-event.ts

@@ -63,7 +63,7 @@ export function isEventEnabled(
 ) {
   if (isHostTextInput(nearestTouchResponder)) {
     return (
-      isTextInputEditable(nearestTouchResponder) ||
+      isTextInputEditable(nearestTouchResponder!) ||
       textInputEventsIgnoringEditableProp.has(eventName)
     );
   }

src/helpers/format.ts

@@ -1,9 +1,9 @@
 import prettyFormat, { NewPlugin, plugins } from 'pretty-format';
-import { JsonNode } from '../renderer/render-to-json';
+import { JsonInstance, JsonNode } from '../renderer/render-to-json';
 
 export type MapPropsFunction = (
   props: Record<string, unknown>,
-  node: JsonNode,
+  node: JsonInstance,
 ) => Record<string, unknown>;
 
 export type FormatOptions = {

src/helpers/host-component-names.tsx

@@ -82,38 +82,38 @@ export function isHostText(element?: HostElement | null) {
  * Checks if the given element is a host TextInput element.
  * @param element The element to check.
  */
-export function isHostTextInput(element?: HostElement | null): element is HostElement {
+export function isHostTextInput(element?: HostElement | null) {
   return element?.type === getHostComponentNames().textInput;
 }
 
 /**
  * Checks if the given element is a host Image element.
  * @param element The element to check.
  */
-export function isHostImage(element?: HostElement | null): element is HostElement {
+export function isHostImage(element?: HostElement | null) {
   return element?.type === getHostComponentNames().image;
 }
 
 /**
  * Checks if the given element is a host Switch element.
  * @param element The element to check.
  */
-export function isHostSwitch(element?: HostElement | null): element is HostElement {
+export function isHostSwitch(element?: HostElement | null) {
   return element?.type === getHostComponentNames().switch;
 }
 
 /**
  * Checks if the given element is a host ScrollView element.
  * @param element The element to check.
  */
-export function isHostScrollView(element?: HostElement | null): element is HostElement {
+export function isHostScrollView(element?: HostElement | null) {
   return element?.type === getHostComponentNames().scrollView;
 }
 
 /**
  * Checks if the given element is a host Modal element.
  * @param element The element to check.
  */
-export function isHostModal(element?: HostElement | null): element is HostElement {
+export function isHostModal(element?: HostElement | null) {
   return element?.type === getHostComponentNames().modal;
 }

src/helpers/matchers/match-label-text.ts

@@ -1,4 +1,5 @@
 import { matches, TextMatch, TextMatchOptions } from '../../matches';
+import { HostElement } from '../../renderer/host-element';
 import { computeAriaLabel, computeAriaLabelledBy } from '../accessibility';
 import { findAll } from '../find-all';
 import { matchTextContent } from './match-text-content';

src/queries/unsafe-type.ts

@@ -67,5 +67,6 @@ export const bindUnsafeByTypeQueries = (instance: HostElement): UnsafeByTypeQuer
 });
 
 function findAllByType(instance: HostElement, type: React.ComponentType<any>) {
+  // @ts-expect-error: React.ComponentType<any> is not compatible with string
   return findAll(instance, (element) => element.type === type);
 }

src/render.tsx

@@ -3,7 +3,6 @@ import { Profiler } from 'react';
 import act from './act';
 import { addToCleanupQueue } from './cleanup';
 import { getConfig } from './config';
-import { getHostChildren } from './helpers/component-tree';
 import debugDeep, { DebugOptions } from './helpers/debug-deep';
 import debugShallow from './helpers/debug-shallow';
 import { configureHostComponentNamesIfNeeded } from './helpers/host-component-names';
@@ -110,7 +109,7 @@ function buildRenderResult(
     toJSON: renderer.toJSON,
     debug: debug(instance, renderer),
     get root(): HostElement {
-      return getHostChildren(instance)[0];
+      return renderer.root;
     },
     UNSAFE_root: instance,
   };

src/renderer/renderer.ts

@@ -1,13 +1,13 @@
 import { ReactElement } from 'react';
 import { Container, TestReconciler } from './reconciler';
 import { JsonNode, renderChildrenToJson, renderToJson } from './render-to-json';
-import { HostElement, HostNode } from './host-element';
+import { HostElement } from './host-element';
 
 export type RenderResult = {
   update: (element: ReactElement) => void;
   unmount: () => void;
   container: HostElement;
-  root: HostNode;
+  root: HostElement;
   toJSON: () => JsonNode | JsonNode[] | null;
 };
 
@@ -105,7 +105,7 @@ export function render(element: ReactElement): RenderResult {
       return HostElement.fromContainer(container);
     },
 
-    get root(): HostNode {
+    get root(): HostElement {
       if (containerFiber == null || container == null) {
         throw new Error("Can't access .root on unmounted test renderer");
       }
@@ -114,7 +114,12 @@ export function render(element: ReactElement): RenderResult {
         throw new Error("Can't access .root on unmounted test renderer");
       }
 
-      return HostElement.fromInstance(container.children[0]);
+      const root = HostElement.fromInstance(container.children[0]);
+      if (typeof root === 'string') {
+        throw new Error('Cannot render string as root element');
+      }
+
+      return root;
     },
   };