Skip to content

Commit 37d8bac

Browse files
committed
OpenAIService - support for after and limit for listFineTuneEvents
1 parent b017da2 commit 37d8bac

File tree

3 files changed

+14
-10
lines changed

3 files changed

+14
-10
lines changed

openai-client/src/main/scala/io/cequence/openaiscala/service/OpenAIServiceImpl.scala

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -325,12 +325,16 @@ private trait OpenAIServiceImpl extends OpenAICoreServiceImpl with OpenAIService
325325
).map(response => handleNotFoundAndError(response).map(_.asSafe[FineTuneJob]))
326326

327327
override def listFineTuneEvents(
328-
fineTuneId: String
328+
fineTuneId: String,
329+
after: Option[String] = None,
330+
limit: Option[Int] = None
329331
): Future[Option[Seq[FineTuneEvent]]] =
330332
execGETWithStatus(
331333
EndPoint.fine_tunes,
332334
endPointParam = Some(s"$fineTuneId/events"),
333335
params = Seq(
336+
Param.after -> after,
337+
Param.limit -> limit,
334338
Param.stream -> Some(false) // TODO: is streaming still supported?
335339
)
336340
).map { response =>

openai-core/src/main/scala/io/cequence/openaiscala/service/OpenAIService.scala

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -123,8 +123,7 @@ trait OpenAIService extends OpenAICoreService {
123123
* image response (might contain multiple data items - one per image)
124124
*
125125
* @see
126-
* <a href="https://platform.openai.com/docs/api-reference/images/create-edit">OpenAI
127-
* Doc</a>
126+
* <a https://platform.openai.com/docs/api-reference/images/createEdit">OpenAI Doc</a>
128127
*/
129128
def createImageEdit(
130129
prompt: String,
@@ -144,7 +143,7 @@ trait OpenAIService extends OpenAICoreService {
144143
* image response (might contain multiple data items - one per image)
145144
*
146145
* @see
147-
* <a href="https://platform.openai.com/docs/api-reference/images/create-variation">OpenAI
146+
* <a href="https://platform.openai.com/docs/api-reference/images/createVariation">OpenAI
148147
* Doc</a>
149148
*/
150149
def createImageVariation(
@@ -375,11 +374,10 @@ trait OpenAIService extends OpenAICoreService {
375374
* <a href="https://platform.openai.com/docs/api-reference/fine-tuning/list-events">OpenAI
376375
* Doc</a>
377376
*/
378-
// TODO: add pagination: after: Option[String], limit: Option[Int]
379377
def listFineTuneEvents(
380-
fineTuneId: String
381-
// after: Option[String] = None,
382-
// limit: Option[Int] = None
378+
fineTuneId: String,
379+
after: Option[String] = None,
380+
limit: Option[Int] = None
383381
): Future[Option[Seq[FineTuneEvent]]]
384382

385383
/**

openai-core/src/main/scala/io/cequence/openaiscala/service/OpenAIServiceWrapper.scala

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -159,9 +159,11 @@ trait OpenAIServiceWrapper extends OpenAIService {
159159
)
160160

161161
override def listFineTuneEvents(
162-
fineTuneId: String
162+
fineTuneId: String,
163+
after: Option[String],
164+
limit: Option[Int]
163165
): Future[Option[Seq[FineTuneEvent]]] = wrap(
164-
_.listFineTuneEvents(fineTuneId)
166+
_.listFineTuneEvents(fineTuneId, after, limit)
165167
)
166168

167169
override def deleteFineTuneModel(

0 commit comments

Comments
 (0)