refactor: name variable

Author: cesargb

src/Processors/AbstractProcessor.php

@@ -4,39 +4,36 @@
 
 abstract class AbstractProcessor
 {
-    private string $fileOut;
+    protected string $filenameSource;
 
-    protected string $fileOriginal;
+    protected string $extension = '';
 
-    protected string $suffix = '';
-
-    abstract public function handler($file): ?string;
+    abstract public function handler(string $filename): ?string;
 
     public function __construct()
     {
         clearstatcache();
     }
 
-    public function compress(): void
+    public function addExtension(string $extension): void
     {
-        $this->suffix = '.gz';
+        $this->extension = '.'.$extension;
     }
 
-    public function setFileOriginal($fileOriginal): self
+    public function removeExtention(string $extension): void
     {
-        $this->fileOriginal = $fileOriginal;
-
-        return $this;
+        $this->extension = str_replace('.'.$extension, '', $this->extension);
     }
 
-    protected function processed($file): ?string
+    public function setFilenameSource($filenameSource): self
     {
-        if (is_file($file)) {
-            $this->fileOut = $file;
+        $this->filenameSource = $filenameSource;
 
-            return $this->fileOut;
-        }
+        return $this;
+    }
 
-        return null;
+    protected function processed(string $filename): ?string
+    {
+        return is_file($filename) ? $filename : null;
     }
 }

src/Processors/RotativeProcessor.php

@@ -7,10 +7,7 @@ class RotativeProcessor extends AbstractProcessor
     private $maxFiles = 366;
 
     /**
-     * Log files are rotated count times before being removed
-     *
-     * @param int $count
-     * @return self
+     * Log files are rotated count times before being removed.
      */
     public function files(int $count): self
     {
@@ -19,47 +16,37 @@ public function files(int $count): self
         return $this;
     }
 
-    public function handler($file): ?string
+    public function handler(string $filename): ?string
     {
-        $nextFile = "{$this->fileOriginal}.1";
+        $filenameTarget = "{$this->filenameSource}.1";
 
         $this->rotate();
 
-        rename($file, $nextFile);
+        rename($filename, $filenameTarget);
 
-        return $this->processed($nextFile);
+        return $this->processed($filenameTarget);
     }
 
     private function rotate(int $number = 1): string
     {
-        $file = "{$this->fileOriginal}.{$number}{$this->suffix}";
+        $filenameTarget = "{$this->filenameSource}.{$number}{$this->extension}";
 
-        if (!file_exists($file)) {
-            return "{$this->fileOriginal}.{$number}{$this->suffix}";
+        if (!file_exists($filenameTarget)) {
+            return $filenameTarget;
         }
 
-        if ($this->maxFiles > 0 && $number >= $this->maxFiles ) {
-            if (file_exists($file)) {
-                unlink($file);
+        if ($this->maxFiles > 0 && $number >= $this->maxFiles) {
+            if (file_exists($filenameTarget)) {
+                unlink($filenameTarget);
             }
 
-            return "{$this->fileOriginal}.{$number}{$this->suffix}";
+            return $filenameTarget;
         }
 
-        $nextFile = $this->rotate($number + 1);
+        $nextFilename = $this->rotate($number + 1);
 
-        rename($file, $nextFile);
+        rename($filenameTarget, $nextFilename);
 
-        return "{$this->fileOriginal}.{$number}{$this->suffix}";
-    }
-
-    private function getnumber(string $file): ?int
-    {
-        $fileName = basename($file);
-        $fileOriginaleName = basename($this->fileOriginal);
-
-        preg_match("/{$fileOriginaleName}.([0-9]+){$this->suffix}/", $fileName, $output);
-
-        return $output[1] ?? null;
+        return $filenameTarget;
     }
 }