[MERGE #5824 @MikeHolman] surface oop jit on windows builds of chakracore

Merge pull request #5824 from MikeHolman:coreoopjit

Resolves #5793

To use this, you will need to create a process to use as the JIT process and in it do the following:

````
UUID connectionId;
UuidCreate(&connectionId);
void* securityDescriptor = nullptr; // initialize security descriptor (only applicable on win8+)
void* alpcSecurityDescriptor = nullptr; // initialize alpc security descriptor
JsInitializeJITServer(connectionId, securityDescriptor, alpcSecurityDescriptor);
````

You will need to pass the `connectionId` and a process handle of the JIT process to your JS runtime process, and call the following:
````
void* securityDescriptor = nullptr; // initialize security descriptor (only applicable on win8+)
JsConnectJITProcess(jitProcessHandle, connectionId, securityDescriptor)
````

Notes:
`JsConnectJITProcess` should be called before executing any script, and should only be called once per JS runtime process.
The host should ensure that the JS runtime process does not hold any handles to the JIT process once script execution begins.
The host must enable ACG on the JS runtime process in order to get a security benefit from out-of-process JIT.
You can connect any number of JS runtime processes to a single JIT process.

Author: MikeHolman

bin/ChakraCore/TestHooks.cpp

@@ -68,16 +68,6 @@ HRESULT __stdcall SetEnableCheckMemoryLeakOutput(bool flag)
     return S_OK;
 }
 
-#if ENABLE_NATIVE_CODEGEN
-#ifdef _WIN32
-void __stdcall ConnectJITServer(HANDLE processHandle, void* serverSecurityDescriptor, UUID connectionId)
-{
-    JITManager::GetJITManager()->EnableOOPJIT();
-    ThreadContext::SetJITConnectionInfo(processHandle, serverSecurityDescriptor, connectionId);
-}
-#endif
-#endif
-
 void __stdcall NotifyUnhandledException(PEXCEPTION_POINTERS exceptionInfo)
 {
 #ifdef GENERATE_DUMP
@@ -203,9 +193,6 @@ HRESULT OnChakraCoreLoaded(OnChakraCoreLoadedPtr pfChakraCoreLoaded)
 #undef FLAG_NumberPairSet
 #undef FLAG_NumberTrioSet
 #undef FLAG_NumberRange
-#if ENABLE_NATIVE_CODEGEN && _WIN32
-        ConnectJITServer,
-#endif
         NotifyUnhandledException
     };
     return pfChakraCoreLoaded(testHooks);

bin/ChakraCore/TestHooks.h

@@ -69,13 +69,6 @@ struct TestHooks
 #undef FLAG_NumberTrioSet
 #undef FLAG_NumberRange
 
-#if ENABLE_NATIVE_CODEGEN
-#ifdef _WIN32
-    typedef void(TESTHOOK_CALL * ConnectJITServer)(HANDLE processHandle, void* serverSecurityDescriptor, UUID connectionId);
-    ConnectJITServer pfnConnectJITServer;
-#endif
-#endif
-
     NotifyUnhandledExceptionPtr pfnNotifyUnhandledException;
 };
 

bin/ch/ChakraRtInterface.cpp

@@ -178,6 +178,9 @@ bool ChakraRTInterface::LoadChakraDll(ArgInfo* argInfo, HINSTANCE *outLibrary)
     m_jsApiHooks.pfJsrtTTDGetSnapTimeTopLevelEventMove = (JsAPIHooks::JsrtTTDGetSnapTimeTopLevelEventMovePtr)GetChakraCoreSymbol(library, "JsTTDGetSnapTimeTopLevelEventMove");
     m_jsApiHooks.pfJsrtTTDMoveToTopLevelEvent = (JsAPIHooks::JsrtTTDMoveToTopLevelEventPtr)GetChakraCoreSymbol(library, "JsTTDMoveToTopLevelEvent");
     m_jsApiHooks.pfJsrtTTDReplayExecution = (JsAPIHooks::JsrtTTDReplayExecutionPtr)GetChakraCoreSymbol(library, "JsTTDReplayExecution");
+#ifdef _WIN32
+    m_jsApiHooks.pfJsrtConnectJITProcess = (JsAPIHooks::JsrtConnectJITProcess)GetChakraCoreSymbol(library, "JsConnectJITProcess");
+#endif
 #endif
 
     return true;

bin/ch/ChakraRtInterface.h

@@ -112,6 +112,10 @@ struct JsAPIHooks
     typedef JsErrorCode(WINAPI *JsrtTTDMoveToTopLevelEventPtr)(JsRuntimeHandle runtimeHandle, JsTTDMoveMode moveMode, int64_t snapshotStartTime, int64_t eventTime);
     typedef JsErrorCode(WINAPI *JsrtTTDReplayExecutionPtr)(JsTTDMoveMode* moveMode, int64_t* rootEventTime);
 
+#ifdef _WIN32
+    typedef JsErrorCode(WINAPI *JsrtConnectJITProcess)(HANDLE processHandle, void* serverSecurityDescriptor, UUID connectionId);
+#endif
+
     JsrtCreateRuntimePtr pfJsrtCreateRuntime;
     JsrtCreateContextPtr pfJsrtCreateContext;
     JsrtSetObjectBeforeCollectCallbackPtr pfJsrtSetObjectBeforeCollectCallback;
@@ -217,6 +221,10 @@ struct JsAPIHooks
     JsrtTTDGetSnapTimeTopLevelEventMovePtr pfJsrtTTDGetSnapTimeTopLevelEventMove;
     JsrtTTDMoveToTopLevelEventPtr pfJsrtTTDMoveToTopLevelEvent;
     JsrtTTDReplayExecutionPtr pfJsrtTTDReplayExecution;
+
+#ifdef _WIN32
+    JsrtConnectJITProcess pfJsrtConnectJITProcess;
+#endif
 };
 
 #ifdef _WIN32
@@ -307,18 +315,6 @@ class ChakraRTInterface
 #endif
     }
 
-#ifdef _WIN32
-#if ENABLE_NATIVE_CODEGEN
-    static void ConnectJITServer(HANDLE processHandle, void* serverSecurityDescriptor, UUID connectionId)
-    {
-        if (m_testHooksSetup && m_testHooks.pfnConnectJITServer != NULL)
-        {
-            m_testHooks.pfnConnectJITServer(processHandle, serverSecurityDescriptor, connectionId);
-        }
-    }
-#endif
-#endif
-
     static void NotifyUnhandledException(PEXCEPTION_POINTERS exceptionInfo)
     {
         if (m_testHooksSetup && m_testHooks.pfnNotifyUnhandledException != NULL)
@@ -442,6 +438,9 @@ class ChakraRTInterface
     static JsErrorCode WINAPI JsQueueBackgroundParse_Experimental(JsScriptContents* contents, DWORD* dwBgParseCookie) { return HOOK_JS_API(QueueBackgroundParse_Experimental)(contents, dwBgParseCookie);  }
     static JsErrorCode WINAPI JsDiscardBackgroundParse_Experimental(DWORD dwBgParseCookie, void* buffer, bool* callerOwnsBuffer) { return HOOK_JS_API(DiscardBackgroundParse_Experimental(dwBgParseCookie, buffer, callerOwnsBuffer)); }
     static JsErrorCode WINAPI JsExecuteBackgroundParse_Experimental(DWORD dwBgParseCookie, JsValueRef script, JsSourceContext sourceContext, WCHAR *url, JsParseScriptAttributes parseAttributes, JsValueRef parserState, JsValueRef *result) { return HOOK_JS_API(ExecuteBackgroundParse_Experimental(dwBgParseCookie, script, sourceContext, url, parseAttributes, parserState, result)); }
+#ifdef _WIN32
+    static JsErrorCode WINAPI JsConnectJITProcess(HANDLE processHandle, void* serverSecurityDescriptor, UUID connectionId) { return HOOK_JS_API(ConnectJITProcess(processHandle, serverSecurityDescriptor, connectionId)); }
+#endif
 };
 
 class AutoRestoreContext

bin/ch/ch.cpp

@@ -1298,7 +1298,7 @@ int _cdecl wmain(int argc, __in_ecount(argc) LPWSTR argv[])
         {
             // TODO: Error checking
             JITProcessManager::StartRpcServer(argc, argv);
-            ChakraRTInterface::ConnectJITServer(JITProcessManager::GetRpcProccessHandle(), nullptr, JITProcessManager::GetRpcConnectionId());
+            ChakraRTInterface::JsConnectJITProcess(JITProcessManager::GetRpcProccessHandle(), nullptr, JITProcessManager::GetRpcConnectionId());
         }
 #endif
         HANDLE threadHandle;

lib/JITClient/JITManager.cpp

@@ -67,22 +67,22 @@ JITManager::CreateBinding(
     RPC_BINDING_HANDLE_TEMPLATE_V1 bindingTemplate;
     RPC_BINDING_HANDLE_SECURITY_V1_W bindingSecurity;
 
-#ifndef NTBUILD
-    RPC_SECURITY_QOS_V4 securityQOS;
-    ZeroMemory(&securityQOS, sizeof(RPC_SECURITY_QOS_V4));
-    securityQOS.Capabilities = RPC_C_QOS_CAPABILITIES_DEFAULT;
-    securityQOS.IdentityTracking = RPC_C_QOS_IDENTITY_DYNAMIC;
-    securityQOS.ImpersonationType = RPC_C_IMP_LEVEL_IDENTIFY;
-    securityQOS.Version = 4;
-#else
+#if (NTDDI_VERSION >= NTDDI_WIN8)
     RPC_SECURITY_QOS_V5 securityQOS;
     ZeroMemory(&securityQOS, sizeof(RPC_SECURITY_QOS_V5));
     securityQOS.Capabilities = RPC_C_QOS_CAPABILITIES_DEFAULT;
     securityQOS.IdentityTracking = RPC_C_QOS_IDENTITY_DYNAMIC;
     securityQOS.ImpersonationType = RPC_C_IMP_LEVEL_IDENTIFY;
     securityQOS.Version = 5;
     securityQOS.ServerSecurityDescriptor = serverSecurityDescriptor;
-#endif // NTBUILD
+#else
+    RPC_SECURITY_QOS_V4 securityQOS;
+    ZeroMemory(&securityQOS, sizeof(RPC_SECURITY_QOS_V4));
+    securityQOS.Capabilities = RPC_C_QOS_CAPABILITIES_DEFAULT;
+    securityQOS.IdentityTracking = RPC_C_QOS_IDENTITY_DYNAMIC;
+    securityQOS.ImpersonationType = RPC_C_IMP_LEVEL_IDENTIFY;
+    securityQOS.Version = 4;
+#endif
 
     ZeroMemory(&bindingTemplate, sizeof(bindingTemplate));
     bindingTemplate.Version = 1;

lib/JITServer/JITServer.cpp

@@ -27,25 +27,25 @@ HRESULT JsInitializeJITServer(
         return status;
     }
 
-#ifndef NTBUILD
-    status = RpcServerRegisterIf2(
+#if (NTDDI_VERSION >= NTDDI_WIN8)
+    status = RpcServerRegisterIf3(
         ServerIChakraJIT_v0_0_s_ifspec,
         NULL,
         NULL,
         RPC_IF_AUTOLISTEN,
         RPC_C_LISTEN_MAX_CALLS_DEFAULT,
         (ULONG)-1,
-        NULL);
+        NULL,
+        securityDescriptor);
 #else
-    status = RpcServerRegisterIf3(
+    status = RpcServerRegisterIf2(
         ServerIChakraJIT_v0_0_s_ifspec,
         NULL,
         NULL,
         RPC_IF_AUTOLISTEN,
         RPC_C_LISTEN_MAX_CALLS_DEFAULT,
         (ULONG)-1,
-        NULL,
-        securityDescriptor);
+        NULL);
 #endif
     if (status != RPC_S_OK)
     {

lib/Jsrt/Chakra.Jsrt.vcxproj

@@ -1,4 +1,4 @@
-<?xml version="1.0" encoding="utf-8"?>
+<?xml version="1.0" encoding="utf-8"?>
 <Project DefaultTargets="Build" ToolsVersion="12.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
   <Import Condition="'$(ChakraBuildPathImported)'!='true'" Project="$(SolutionDir)Chakra.Build.Paths.props" />
   <Import Project="$(BuildConfigPropsPath)Chakra.Build.ProjectConfiguration.props" />
@@ -61,6 +61,7 @@
     <ClInclude Include="ChakraCommon.h" />
     <ClInclude Include="ChakraCommonWindows.h" />
     <ClInclude Include="ChakraCore.h" />
+    <ClInclude Include="ChakraCoreWindows.h" />
     <ClInclude Include="ChakraDebug.h" />
     <ClInclude Include="JsrtContext.h" />
     <ClInclude Include="JsrtDebugManager.h" />
@@ -89,4 +90,4 @@
   </ItemGroup>
   <Import Project="$(BuildConfigPropsPath)Chakra.Build.targets" Condition="exists('$(BuildConfigPropsPath)Chakra.Build.targets')" />
   <Import Project="$(VCTargetsPath)\Microsoft.Cpp.targets" />
-</Project>
+</Project>

lib/Jsrt/ChakraCore.h

@@ -1271,5 +1271,10 @@ CHAKRA_API
         _In_ JsValueRef parserState,
         _Out_ JsValueRef * result);
 
+
+#ifdef _WIN32
+#include "ChakraCoreWindows.h"
+#endif // _WIN32
+
 #endif // _CHAKRACOREBUILD
 #endif // _CHAKRACORE_H_

lib/Jsrt/ChakraCoreWindows.h

@@ -0,0 +1,28 @@
+//-------------------------------------------------------------------------------------------------------
+// Copyright (C) Microsoft. All rights reserved.
+// Licensed under the MIT license. See LICENSE.txt file in the project root for full license information.
+//-------------------------------------------------------------------------------------------------------
+
+#ifdef _MSC_VER
+#pragma once
+#endif // _MSC_VER
+
+#ifndef _CHAKRACOREWINDOWS_H_
+#define _CHAKRACOREWINDOWS_H_
+
+/// <summary>
+///     Enables out-of-process JIT by connecting to a Chakra JIT process that was initialized by calling JsInitializeJITServer
+/// </summary>
+/// <remarks>
+///     Should be called before JS code is executed.
+/// </remarks>
+/// <param name="processHandle">Handle to the JIT process</param>
+/// <param name="serverSecurityDescriptor">Optional pointer to an RPC SECURITY_DESCRIPTOR structure</param>
+/// <param name="connectionId">Same UUID that was passed to JsInitializeJITServer</param>
+/// <returns>
+///     The code <c>JsNoError</c> if the operation succeeded, a failure code otherwise.
+/// </returns>
+CHAKRA_API
+JsConnectJITProcess(_In_ HANDLE processHandle, _In_opt_ void* serverSecurityDescriptor, _In_ UUID connectionId);
+
+#endif // _CHAKRACOREWINDOWS_H_