fix: merge duplicate chunks after split chunks

Author: alexander-akait

lib/optimize/MergeDuplicateChunksPlugin.js

@@ -5,7 +5,7 @@
 
 "use strict";
 
-const { STAGE_BASIC } = require("../OptimizationStages");
+const { STAGE_ADVANCED } = require("../OptimizationStages");
 const { runtimeEqual } = require("../util/runtime");
 
 /** @typedef {import("../Compiler")} Compiler */
@@ -22,7 +22,7 @@ class MergeDuplicateChunksPlugin {
 				compilation.hooks.optimizeChunks.tap(
 					{
 						name: "MergeDuplicateChunksPlugin",
-						stage: STAGE_BASIC
+						stage: STAGE_ADVANCED
 					},
 					chunks => {
 						const { chunkGraph, moduleGraph } = compilation;

test/__snapshots__/StatsTestCases.basictest.js.snap

@@ -4097,6 +4097,29 @@ chunk (runtime: main) 914.js X bytes <{792}> ={60}= ={263}= [rendered] split chu
 webpack x.x.x compiled successfully"
 `;
 
+exports[`StatsTestCases should print correct stats for split-chunks-dedup 1`] = `
+"asset main.js X KiB [emitted] (name: main) (id hint: main)
+asset table-643--shared.js X bytes [emitted]
+asset row-359--shared.js X bytes [emitted]
+asset cell--shared.js X bytes [emitted]
+asset templater--shared.js X bytes [emitted]
+runtime modules X KiB 11 modules
+built modules X bytes (javascript) X bytes (share-init) X bytes (consume-shared) [built]
+  cacheable modules X bytes
+    modules by path ./node_modules/ X bytes 4 modules
+    modules by path ./*.js X bytes 2 modules
+  provide-module modules X bytes
+    provide shared module (default) cell@1.0.0 = ./node_modules/cell/index.js X bytes [built] [code generated]
+    provide shared module (default) row@1.0.0 = ./node_modules/row/index.js X bytes [built] [code generated]
+    + 2 modules
+  consume-shared-module modules X bytes
+    consume shared module (default) table@=1.0.0 (strict) (fallback: ./node_modules/...(truncated) X bytes [built] [code generated]
+    consume shared module (default) row@=1.0.0 (strict) (fallback: ./node_modules...(truncated) X bytes [built] [code generated]
+    consume shared module (default) templater@=1.0.0 (strict) (fallback: ./node_modu...(truncated) X bytes [built] [code generated]
+    consume shared module (default) cell@=1.0.0 (strict) (fallback: ./node_modules/...(truncated) X bytes [built] [code generated]
+webpack x.x.x compiled successfully in X ms"
+`;
+
 exports[`StatsTestCases should print correct stats for split-chunks-issue-6413 1`] = `
 "Entrypoint main X KiB = main.js
 chunk (runtime: main) async-b.js (async-b) X bytes <{792}> ={476}= ={628}= [rendered]
@@ -4790,22 +4813,22 @@ assets by path *.wasm X KiB
   asset XXXXXXXXXXXXXXXXXXXX.module.wasm X bytes [emitted] [immutable]
   asset XXXXXXXXXXXXXXXXXXXX.module.wasm X bytes [emitted] [immutable]
   asset XXXXXXXXXXXXXXXXXXXX.module.wasm X bytes [emitted] [immutable]
-chunk (runtime: main) 573.bundle.js X bytes (javascript) X bytes (webassembly) [rendered]
+chunk (runtime: main) 573.bundle.js X bytes (javascript) X bytes (webassembly) [rendered] reused as split chunk (cache group: default)
   ./Q_rsqrt.wasm X bytes (javascript) X bytes (webassembly) [built] [code generated]
-chunk (runtime: main) 672.bundle.js X bytes (javascript) X bytes (webassembly) [rendered]
+chunk (runtime: main) 672.bundle.js X bytes (javascript) X bytes (webassembly) [rendered] reused as split chunk (cache group: default)
   ./duff.wasm X bytes (javascript) X bytes (webassembly) [built] [code generated]
 chunk (runtime: main) 787.bundle.js (id hint: vendors) X bytes [rendered] split chunk (cache group: defaultVendors)
   ./node_modules/env.js X bytes [built] [code generated]
 chunk (runtime: main) bundle.js (main) X bytes (javascript) X KiB (runtime) [entry] [rendered]
   runtime modules X KiB 11 modules
   ./index.js X bytes [built] [code generated]
-chunk (runtime: main) 836.bundle.js X KiB (javascript) X bytes (webassembly) [rendered]
+chunk (runtime: main) 836.bundle.js X KiB (javascript) X bytes (webassembly) [rendered] reused as split chunk (cache group: default)
   ./testFunction.wasm X bytes (javascript) X bytes (webassembly) [dependent] [built] [code generated]
   ./tests.js X KiB [built] [code generated]
-chunk (runtime: main) 946.bundle.js X bytes (javascript) X bytes (webassembly) [rendered]
+chunk (runtime: main) 946.bundle.js X bytes (javascript) X bytes (webassembly) [rendered] reused as split chunk (cache group: default)
   ./fact.wasm X bytes (javascript) X bytes (webassembly) [built] [code generated]
   ./fast-math.wasm X bytes (javascript) X bytes (webassembly) [built] [code generated]
-chunk (runtime: main) 989.bundle.js X bytes (javascript) X bytes (webassembly) [rendered]
+chunk (runtime: main) 989.bundle.js X bytes (javascript) X bytes (webassembly) [rendered] reused as split chunk (cache group: default)
   ./popcnt.wasm X bytes (javascript) X bytes (webassembly) [built] [code generated]
 runtime modules X KiB 11 modules
 cacheable modules X KiB (javascript) X KiB (webassembly)

test/statsCases/split-chunks-dedup/index.js

@@ -0,0 +1,5 @@
+export default async () => {
+	const { test } = await import(/* webpackMode: "eager" */'./module')
+
+	test()
+};

test/statsCases/split-chunks-dedup/module.js

@@ -0,0 +1,5 @@
+import { table } from 'table'
+
+export function test() {
+    expect(table([['1']])).toBe('<table><tr><td>1</td></tr></table>')
+}