🚿 test coverage

Author: codemasher

src/Foursquare/Foursquare.php

@@ -47,12 +47,7 @@ public function request(
 		array $headers = null
 	):ResponseInterface{
 
-		$queryparams = [];
-		$querystring = parseUrl($this->apiURL.$path)['query'] ?? '';
-
-		if(!empty($querystring)){
-			$queryparams = $this->parseQuery($querystring);
-		}
+		$queryparams = $this->parseQuery(parseUrl($this->apiURL.$path)['query'] ?? '');
 
 		$queryparams['v'] = $this::API_VERSIONDATE;
 		$queryparams['m'] = 'foursquare';

src/Steam/SteamOpenID.php

@@ -134,6 +134,7 @@ protected function parseTokenResponse(ResponseInterface $response):AccessToken{
 
 		// the response is only validation, so we'll just return an empty token and add the id in the next step
 		return new AccessToken([
+			'accessToken' => 'SteamID',
 			'provider' => $this->serviceName,
 			'expires'  => AccessToken::EOL_NEVER_EXPIRES,
 		]);

tests/Steam/SteamOpenIDTest.php

@@ -10,6 +10,7 @@
 
 namespace chillerlan\OAuthTest\Providers\Steam;
 
+use chillerlan\OAuth\Core\ProviderException;
 use chillerlan\OAuth\Providers\Steam\SteamOpenID;
 use chillerlan\OAuthTest\Providers\OAuthProviderTestAbstract;
 
@@ -20,16 +21,21 @@
  */
 class SteamOpenIDTest extends OAuthProviderTestAbstract{
 
+	protected const ID_VALID   = "ns:http://specs.openid.net/auth/2.0\x0ais_valid:true\x0a";
+	protected const ID_INVALID = "ns:http://specs.openid.net/auth/2.0\x0ais_valid:false\x0a";
+
 	protected string $FQN = SteamOpenID::class;
 
 	protected array $testResponses = [
-		'/steam/id' => "ns:http://specs.openid.net/auth/2.0\x0ais_valid:true\x0a",
+		'/steam/id'          => self::ID_VALID,
+		'/steam/api/request' => '{"data":"such data! much wow!"}',
 	];
 
 	protected function setUp():void{
 		parent::setUp(); // TODO: Change the autogenerated stub
 
 		$this->setProperty($this->provider, 'accessTokenURL', 'https://localhost/steam/id');
+		$this->setProperty($this->provider, 'apiURL', '/steam/api/request');
 	}
 
 	public function testGetAuthURL():void{
@@ -63,4 +69,49 @@ public function testGetAccessToken():void{
 
 		$this::assertSame('69420', $this->provider->getAccessToken($received)->accessToken);
 	}
+
+	public function testParseTokenResponse():void{
+		$r = $this->responseFactory
+			->createResponse()
+			->withBody($this->streamFactory->createStream(self::ID_VALID))
+		;
+
+		$token = $this
+			->getMethod('parseTokenResponse')
+			->invokeArgs($this->provider, [$r]);
+
+		$this::assertSame('SteamID', $token->accessToken);
+	}
+
+	public function testParseTokenResponseNoData():void{
+		$this->expectException(ProviderException::class);
+		$this->expectExceptionMessage('unable to parse token response');
+
+		$this
+			->getMethod('parseTokenResponse')
+			->invokeArgs($this->provider, [$this->responseFactory->createResponse()]);
+	}
+
+	public function testParseTokenResponseInvalidID():void{
+		$this->expectException(ProviderException::class);
+		$this->expectExceptionMessage('invalid id');
+
+		$r = $this->responseFactory
+			->createResponse()
+			->withBody($this->streamFactory->createStream(self::ID_INVALID))
+		;
+
+		$this
+			->getMethod('parseTokenResponse')
+			->invokeArgs($this->provider, [$r]);
+	}
+
+	// coverage
+	public function testRequest():void{
+		$r = $this->provider->request('');
+
+		$this::assertSame('such data! much wow!', $this->responseJson($r)->data);
+	}
+
+
 }