🚿 reduce empty() usages

Author: codemasher

src/Core/AuthenticatedUser.php

@@ -130,7 +130,7 @@ protected function set_displayName(string|null $displayName):void{
 
 		$displayName = trim($displayName);
 
-		if(!empty($displayName)){
+		if($displayName !== ''){
 			$this->displayName = $displayName;
 		}
 

src/Core/OAuth1Provider.php

@@ -104,7 +104,7 @@ protected function getRequestTokenRequestParams():array{
 	protected function parseTokenResponse(ResponseInterface $response, bool|null $checkCallbackConfirmed = null):AccessToken{
 		$data = QueryUtil::parse(MessageUtil::decompress($response));
 
-		if(empty($data)){
+		if($data === []){
 			throw new ProviderException('unable to parse token response');
 		}
 

src/Core/OAuth2Provider.php

@@ -85,7 +85,7 @@ protected function getAuthorizationURLRequestParams(array $params, array $scopes
 			'type'          => 'web_server',
 		]);
 
-		if(!empty($scopes)){
+		if($scopes !== []){
 			$params['scope'] = implode($this::SCOPES_DELIMITER, $scopes);
 		}
 

src/Providers/Deezer.php

@@ -89,7 +89,7 @@ protected function getAccessTokenRequestBodyParams(string $code):array{
 	protected function getTokenResponseData(ResponseInterface $response):array{
 		$data = trim(MessageUtil::getContents($response));
 
-		if(empty($data)){
+		if($data === ''){
 			throw new ProviderException('invalid response');
 		}
 

src/Providers/LastFM.php

@@ -294,7 +294,7 @@ public function scrobble(array $tracks):array{
 			$this->addScrobble($track);
 		}
 
-		if(empty($this->scrobbles)){
+		if($this->scrobbles === []){
 			throw new InvalidArgumentException('no tracks to scrobble'); // @codeCoverageIgnore
 		}
 
@@ -368,7 +368,7 @@ protected function construct():void{
 
 					$this->{$var} = trim($this->{$var});
 
-					if(empty($this->{$var})){
+					if($this->{$var} === ''){
 						throw new InvalidArgumentException(sprintf('variable "%s" must not be empty', $var));
 					}
 				}

src/Storage/OAuthStorageAbstract.php

@@ -77,7 +77,7 @@ public function setLogger(LoggerInterface $logger):static{
 	protected function getProviderName(string $provider):string{
 		$name = trim($provider);
 
-		if(empty($name)){
+		if($name === ''){
 			throw new OAuthStorageException('provider name must not be empty');
 		}