Skip to content

Bugfix: SenderKeyRecord state method always return first state #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bugfix: SenderKeyRecord state method always return first state #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fdb5ac9
fix: return wrong state
Feb 21, 2024
c75b076
add testcase
Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/Encryption/SenderKeyRecord.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ final class SenderKeyRecord {
func state(for id: UInt32) -> SenderKeyState? {
for item in states {
if item.keyId == id {
return state
return item
}
}
return nil
Expand Down
12 changes: 12 additions & 0 deletions Tests/SenderKeyRecordTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,18 @@ class SenderKeyRecordTests: XCTestCase {
chainKey: senderKey2,
signatureKeyPair: senderSigningKey2)

guard let state = record.state(for: stateId1) else {
XCTFail("\(stateId1) missed")
return
}
XCTAssertEqual(state.keyId, stateId1)

guard let state = record.state(for: stateId2) else {
XCTFail("\(stateId2) missed")
return
}
XCTAssertEqual(state.keyId, stateId2)

guard let serialized = try? record.protoData() else {
XCTFail("Could not serialize SenderKeyRecord")
return
Expand Down