Fixing exposing ReactDelegate through ReactActivity for reload() (facebook#44227)

arushikesarwani94 · facebook-github-bot · commit e25860f07c6a · 2024-04-24T00:20:54.000-07:00
Summary: Pull Request resolved: facebook#44227 In facebook#44223 kudo identified the incorrect return type. Reviewed By: christophpurrer, philIip Differential Revision: D56497700 fbshipit-source-id: 5d7fc7ef21c3d3033a2567eba51b613eb41f0a1a
diff --git a/packages/react-native/ReactAndroid/api/ReactAndroid.api b/packages/react-native/ReactAndroid/api/ReactAndroid.api
@@ -93,7 +93,7 @@ public abstract class com/facebook/react/ReactActivity : androidx/appcompat/app/
 	protected fun createReactActivityDelegate ()Lcom/facebook/react/ReactActivityDelegate;
 	protected fun getMainComponentName ()Ljava/lang/String;
 	public fun getReactActivityDelegate ()Lcom/facebook/react/ReactActivityDelegate;
-	public fun getReactDelegate ()V
+	public fun getReactDelegate ()Lcom/facebook/react/ReactDelegate;
 	protected final fun getReactInstanceManager ()Lcom/facebook/react/ReactInstanceManager;
 	protected final fun getReactNativeHost ()Lcom/facebook/react/ReactNativeHost;
 	public fun invokeDefaultOnBackPressed ()V
diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactActivity.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactActivity.java
@@ -65,8 +65,8 @@ protected void onDestroy() {
     mDelegate.onDestroy();
   }
 
-  public void getReactDelegate() {
-    mDelegate.getReactDelegate();
+  public @Nullable ReactDelegate getReactDelegate() {
+    return mDelegate.getReactDelegate();
   }
 
   public ReactActivityDelegate getReactActivityDelegate() {

Original file line number	Diff line number	Diff line change
`@@ -65,8 +65,8 @@ protected void onDestroy() {`
`65`	`65`	`mDelegate.onDestroy();`
`66`	`66`	`}`
`67`	`67`
`68`		`- public void getReactDelegate() {`
`69`		`- mDelegate.getReactDelegate();`
	`68`	`+ public @Nullable ReactDelegate getReactDelegate() {`
	`69`	`+ return mDelegate.getReactDelegate();`
`70`	`70`	`}`
`71`	`71`
`72`	`72`	`public ReactActivityDelegate getReactActivityDelegate() {`